[check:construction] Wait to start check:construction until reaching tip #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4908
💛 - Coveralls |
patrick-ogrady
force-pushed
the
patrick/wait-to-start-until-tip
branch
from
820198a to
6af5313
Compare
patrick-ogrady
force-pushed
the
patrick/wait-to-start-until-tip
branch
from
103be8b to
aa37ee4
Compare
patrick-ogrady
force-pushed
the
patrick/wait-to-start-until-tip
branch
from
201139c to
0e71795
Compare
patrick-ogrady
changed the title
yfl92
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #100
This PR delays the start of
check:constructionuntil an implementation is at tip. This prevents therosetta-clifrom syncing a ton of blocks unnecessarily.Logging Changes
Progress
Waiting to Start
Changes
waitForTipmethod to wait to begin syncing until we are at tip