fix: error handling issues (#363)

Signed-off-by: Jingfu Wang <[email protected]> Signed-off-by: Jingfu Wang <[email protected]>
coinbase · Sep 19, 2022 · 6dd4f30 · 6dd4f30
1 parent 7bb7304
commit 6dd4f30
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/pkg/logger/logger.go b/pkg/logger/logger.go
@@ -286,7 +286,11 @@ func (l *Logger) RemoveBlockStream(
 	)
 	fmt.Print(blockString)
 	_, err = f.WriteString(blockString)
-	return fmt.Errorf("failed to write block string %s: %w", blockString, err)
+	if err != nil {
+		return fmt.Errorf("failed to write block string %s: %w", blockString, err)
+	}
+
+	return nil
 }
 
 // TransactionStream writes the next processed block's transactions

diff --git a/pkg/processor/balance_storage_handler.go b/pkg/processor/balance_storage_handler.go
@@ -125,7 +125,10 @@ func (h *BalanceStorageHandler) AccountsReconciled(
 		modules.ReconciledAccounts,
 		big.NewInt(int64(count)),
 	)
-	return fmt.Errorf("failed to update the total accounts reconciled by count: %w", err)
+	if err != nil {
+		return fmt.Errorf("failed to update the total accounts reconciled by count: %w", err)
+	}
+	return nil
 }
 
 // AccountsSeen updates the total accounts seen by count.
@@ -140,5 +143,8 @@ func (h *BalanceStorageHandler) AccountsSeen(
 		modules.SeenAccounts,
 		big.NewInt(int64(count)),
 	)
-	return fmt.Errorf("failed to update the total accounts seen by count: %w", err)
+	if err != nil {
+		return fmt.Errorf("failed to update the total accounts seen by count: %w", err)
+	}
+	return nil
 }