nits

Makefile

@@ -12,7 +12,7 @@ ADDLICENCE_SCRIPT=${ADDLICENSE_CMD} -c "Coinbase, Inc." -l "apache" -v
 GOLINES_CMD=go run github.com/segmentio/golines
 GOVERALLS_CMD=go run github.com/mattn/goveralls
 COVERAGE_TEST_DIRECTORIES=./configuration/... ./pkg/constructor/... \
-	./pkg/logger/... ./pkg/scenario/... ./pkg/results/...
+	./pkg/logger/... ./pkg/scenario/...
 TEST_SCRIPT=go test -v ./pkg/... ./configuration/...
 COVERAGE_TEST_SCRIPT=go test -v ${COVERAGE_TEST_DIRECTORIES}
 

pkg/results/construction_results.go

@@ -280,9 +280,9 @@ func ComputeCheckConstructionStatus(
 }
 
 // FetchCheckConstructionStatus fetches *CheckConstructionStatus.
-func FetchCheckConstructionStatus(URL string) (*CheckConstructionStatus, error) {
+func FetchCheckConstructionStatus(url string) (*CheckConstructionStatus, error) {
 	var status CheckConstructionStatus
-	if err := JSONFetch(URL, &status); err != nil {
+	if err := JSONFetch(url, &status); err != nil {
 		return nil, fmt.Errorf("%w: unable to fetch construction status", err)
 	}
 

pkg/results/data_results.go

@@ -312,9 +312,9 @@ func ComputeCheckDataStatus(
 }
 
 // FetchCheckDataStatus fetches *CheckDataStatus.
-func FetchCheckDataStatus(URL string) (*CheckDataStatus, error) {
+func FetchCheckDataStatus(url string) (*CheckDataStatus, error) {
 	var status CheckDataStatus
-	if err := JSONFetch(URL, &status); err != nil {
+	if err := JSONFetch(url, &status); err != nil {
 		return nil, fmt.Errorf("%w: unable to fetch construction status", err)
 	}
 

pkg/results/utils.go

@@ -23,10 +23,10 @@ import (
 
 // JSONFetch makes a GET request to the URL and marshals
 // the response into output.
-func JSONFetch(URL string, output interface{}) error {
-	resp, err := http.Get(URL)
+func JSONFetch(url string, output interface{}) error {
+	resp, err := http.Get(url) // #nosec
 	if err != nil {
-		return fmt.Errorf("%w: unable to fetch GET %s", err, URL)
+		return fmt.Errorf("%w: unable to fetch GET %s", err, url)
 	}
 	defer resp.Body.Close()