Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for creating a Uniswap V3 liquidity pool #5

Merged
merged 12 commits into from
Nov 5, 2024
Merged

Added support for creating a Uniswap V3 liquidity pool #5

merged 12 commits into from
Nov 5, 2024

Conversation

rohan-agarwal-coinbase
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase commented Nov 5, 2024 •
edited
Loading

This PR adds support for creating a uniswap v3 liquidity pool.

Testing:

  • Works e2e using chatbot example
  • Added unit tests

@cb-heimdall
Copy link

cb-heimdall commented Nov 5, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@rohan-agarwal-coinbase rohan-agarwal-coinbase marked this pull request as ready for review November 5, 2024 17:52
@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit ac3fafc into master Nov 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-peterson-coinbase John-peterson-coinbase John-peterson-coinbase approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohan-agarwal-coinbase @cb-heimdall @John-peterson-coinbase