Convert everything to C++ and add tests #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atement to this case label
TimSiebert1
changed the title
…leading to a segfault. Before this fix, the macro-function ADOLC_GET_TAYLOR(arg) was called twice if we had situation like a = pow(a, n) where "a" is an adouble. In this case, the location of arg is the same as the location of res. Thus, to obtain the correct input value, we have to read the value of "currTay - 1", which stores the input value of "a" for pow(a, n). However, the function "adub pow(const badouble &x, double coval)" increments the "currTay" pointer once. The next operation would skip its input when calling "ADOLC_GET_TAYLOR" and the last operation (assign_ind) would access a non-valid pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR transforms the C sources to C++ and extends the tests
Its not done yet!