-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to provide cred #11
Open
ncclementi
wants to merge
18
commits into
main
Choose a base branch
from
creds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d4bb6a5
add possibility to provide cred via filename
ncclementi 7b874e8
pass credentials not cred file, broken cannot pickle
ncclementi 1b4c744
add read cred from json
ncclementi 1ec5dea
modify read to include credentials setup
ncclementi 8de4d1e
use pyjwt to create token
ncclementi 8d9c026
add type to cred_token variable
ncclementi 31269f0
fix conflicts
ncclementi 9c9a52a
remove unecessary dependency
ncclementi 5d1b571
use google auth brearer token to authenticate
ncclementi 87601ae
Merge branch 'creds' of github.com:coiled/dask-bigquery into creds
ncclementi 1832d39
change scope to bigquery read only
ncclementi 4673b82
Fix readme mismatch
ncclementi 1ab71c2
add fwd_creds flag to send credentials
ncclementi c73db5b
use of default credentials in fwd_creds instead of env variable
ncclementi 9c885ac
let google.auth.default raise error if no credentials
ncclementi 742526c
add test for when we have when no credentials
ncclementi 2b64304
Merge branch 'main' of github.com:coiled/dask-bigquery into creds
ncclementi 8ec8f0a
Merge branch 'main' of github.com:coiled/dask-bigquery into creds
ncclementi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to call
https://googleapis.dev/python/google-auth/latest/reference/google.auth.html#google.auth.default
instead. That'll find the
GOOGLE_APPLICATIONS_CREDENTIALS
environment variable if available, but also allow for other authentication methods such asgcloud auth application-default login
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe any kind of credentials it returns should have a
refresh
function, just like the service account credentials.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tim, I will take a look at this.