Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Cluster message from TrustZone #130

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Separate Cluster message from TrustZone #130

merged 3 commits into from
Jan 27, 2025

Conversation

markgoddard
Copy link
Contributor

This change modifies cofidectl to adapt to the changes in
cofide/cofide-api-sdk#25, in which the TrustZone
message has been refactored to extract per-Kubernetes cluster details
into a Cluster message.

For now we restrict the number of clusters per trust zone to one.
Clusters are not yet exposed by the CLI as separate from trust zones.
They are currently embedded into trust zones in the data model but will
be referenced by name or ID in future.

Fixes: #126

This change modifies cofidectl to adapt to the changes in
cofide/cofide-api-sdk#25, in which the TrustZone
message has been refactored to extract per-Kubernetes cluster details
into a Cluster message.

For now we restrict the number of clusters per trust zone to one.
Clusters are not yet exposed by the CLI as separate from trust zones.
They are currently embedded into trust zones in the data model but will
be referenced by name or ID in future.

Fixes: #126
@markgoddard markgoddard self-assigned this Jan 17, 2025
@markgoddard markgoddard marked this pull request as ready for review January 20, 2025 13:15
@markgoddard markgoddard enabled auto-merge January 20, 2025 13:15
@nialdaly
Copy link
Contributor

nialdaly commented Jan 27, 2025

This will need a merge from main to resolve the blocking test check (as the step on the current branch is called build-test).

Screenshot 2025-01-27 at 10 11 39

@markgoddard markgoddard merged commit 0c11da2 into main Jan 27, 2025
6 checks passed
@markgoddard markgoddard deleted the cluster branch January 27, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor TrustZone message to extract Cluster
2 participants