Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature component disclosure interaction #278

Closed
wants to merge 6 commits into from
Closed

Feature component disclosure interaction #278

wants to merge 6 commits into from

Conversation

IngaleChinmay04
Copy link

@IngaleChinmay04 IngaleChinmay04 commented Oct 2, 2024 •
edited by sudhashrestha
Loading

The DisclosureInteraction component is an interactive button that expands into a small sheet when clicked. This sheet provides six options (e.g., Project, Task, Note, etc.) and includes a close button to collapse the sheet back to its original state. The component features smooth animations for expanding and collapsing, and is styled using a clean and modern UI design.

Closes #271

Recording.2024-10-03.004638.mp4

hari
hari requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@hari hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not use npm, instead we use yarn. Also, you cannot downgrade the next version. Please remove package-lock and update PR.

animata/button/disclosure-interaction.tsx Outdated
}

.disclosure-sheet {
position: absolute;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use tailwindcss.

content/docs/button/disclosure-interaction.mdx Outdated
---
title: Disclosure Interaction
description: The DisclosureInteraction component is an interactive button that expands into a small sheet when clicked. This sheet provides six options (e.g., Project, Task, Note, etc.) and includes a close button to collapse the sheet back to its original state. The component features smooth animations for expanding and collapsing, and is styled using a clean and modern UI design.
author: YourTwitterUsername
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Twitter username is missing

content/docs/button/disclosure-interaction.mdx Outdated
Comment on lines 17 to 30

<Step>Update `tailwind.config.js`</Step>

Add the following to your tailwind.config.js file.

```json
module.exports = {
theme: {
extend: {
}
}
}
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused steps

content/docs/button/disclosure-interaction.mdx Outdated
Comment on lines 50 to 53

Built by [Your name](https://github.com/YourGithubUsername)

...Add appropriate credits here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this

@hari
Copy link
Contributor

hari commented Oct 3, 2024

Please use 'lucide-react` icons and improve the animation as well :)

@IngaleChinmay04
Copy link
Author

Okay I will work on the issues

@IngaleChinmay04
Copy link
Author

IngaleChinmay04 commented Oct 3, 2024 •
edited
Loading

I've resolved the requested changes, including Tailwind CSS adjustments, lucide-react icons, and animations. Please review the updates.

image

@IngaleChinmay04
Copy link
Author

I mistakenly triggered the preview-deployment for this pull request. Could you please avoid approving the deployment or cancel the approval request?

hari
hari requested changes Oct 3, 2024
View reviewed changes
content/docs/button/disclosure-interaction.mdx Show resolved Hide resolved
package.json Outdated
@@ -46,7 +46,7 @@
"lodash.startcase": "^4.4.0",
"lucide-react": "^0.390.0",
"mdast-util-toc": "^7.1.0",
"next": "14.2.10",
"next": "13.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IngaleChinmay04 Please undo this change (and yarn.lock) changes.

@hari
Copy link
Contributor

hari commented Oct 3, 2024

@IngaleChinmay04 The deployment is automatic and it's nothing to worry.

@IngaleChinmay04
Copy link
Author

I have updated the package.json and added yarn.lock and also steps in mdx file.
Apologies for the inconvenience with these small changes.

hari
hari reviewed Oct 4, 2024
View reviewed changes
yarn.lock Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IngaleChinmay04 yarn.lock is still here. This file shouldn't change as you haven't added any new dependencies.

@IngaleChinmay04
Copy link
Author

I have replcaed the yarn.lock file which was there in main branch to avoid changes

@hari
Copy link
Contributor

hari commented Oct 5, 2024

Your PR should not have the yarn.lock file. The build is failing.

Run yarn install --immutable
➤ YN0000: · Yarn [4](https://github.com/codse/animata/actions/runs/11176462640/job/31069877354?pr=278#step:6:5).2.2
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0000: └ Completed in 0s 2[8](https://github.com/codse/animata/actions/runs/11176462640/job/31069877354?pr=278#step:6:10)3ms
➤ YN0000: ┌ Post-resolution validation
Post-resolution validation
➤ YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.
➤ YN0000: └ Completed
➤ YN0000: · Failed with errors in 0s 387ms

@hari
Copy link
Contributor

hari commented Oct 5, 2024

@IngaleChinmay04 please create a fresh PR with only those 3 files. Make sure to pull the latest main first. I am closing this one.

@hari hari closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hari hari hari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new disclosure interaction
2 participants
@IngaleChinmay04 @hari