DEV2-3175: Fix error logs (#1212)

src/assistant/AssistantHandlers.ts

@@ -13,6 +13,7 @@ import { ASSISTANT_IGNORE_REFRESH_COMMAND } from "./globals";
 import { IgnoreAssistantSelection } from "./IgnoreAssistantSelection";
 import { AcceptAssistantSelection } from "./AcceptAssistantSelection";
 import { setDecorators } from "./diagnostics";
+import { Logger } from "../utils/logger";
 
 const IGNORE_VALUE = "__IGNORE__";
 
@@ -48,7 +49,7 @@ export async function assistantSelectionHandler(
     );
     void setState(eventData);
   } catch (error) {
-    console.error(error);
+    Logger.error(error);
   }
 }
 
@@ -79,7 +80,7 @@ export async function assistantIgnoreHandler(
     );
     void setState(eventData);
   } catch (error) {
-    console.error(error);
+    Logger.error(error);
   }
 }
 

src/binary/Binary.ts

@@ -11,6 +11,7 @@ import {
   BINARY_RESTART_EVENT,
 } from "../globals/consts";
 import { sleep, waitForRejection } from "../utils/utils";
+import { Logger } from "../utils/logger";
 
 type RestartCallback = () => void;
 
@@ -62,7 +63,7 @@ export default class Binary {
       }
 
       if (this.isBinaryDead()) {
-        console.warn("Binary died. It is being restarted.");
+        Logger.warn("Binary died. It is being restarted.");
         await this.restartChild();
 
         return null;
@@ -78,10 +79,10 @@ export default class Binary {
 
       return result;
     } catch (err) {
-      console.error(err);
+      Logger.error(err);
       this.requestFailures += 1;
       if (this.requestFailures > REQUEST_FAILURES_THRESHOLD) {
-        console.warn("Binary not returning results, it is being restarted.");
+        Logger.warn("Binary not returning results, it is being restarted.");
         await this.restartChild();
       }
     } finally {
@@ -127,23 +128,23 @@ export default class Binary {
     this.proc = proc;
     this.proc.unref(); // AIUI, this lets Node exit without waiting for the child
     this.proc.on("exit", (code, signal) => {
-      console.warn(
+      Logger.warn(
         `Binary child process exited with code ${code ?? "unknown"} signal ${
           signal ?? "unknown"
         }`
       );
       void this.restartChild();
     });
     this.proc.on("error", (error) => {
-      console.warn(`Binary child process error: ${error.message}`);
+      Logger.warn(`Binary child process error: ${error.message}`);
       void this.restartChild();
     });
     this.proc.stdin?.on("error", (error) => {
-      console.warn(`Binary child process stdin error: ${error.message}`);
+      Logger.warn(`Binary child process stdin error: ${error.message}`);
       void this.restartChild();
     });
     this.proc.stdout?.on("error", (error) => {
-      console.warn(`Binary child process stdout error: ${error.message}`);
+      Logger.warn(`Binary child process stdout error: ${error.message}`);
       void this.restartChild();
     });
 

src/binary/binaryFetcher/activeFileHandler.ts

@@ -1,6 +1,7 @@
 import * as fs from "fs";
 import { getActivePath, versionPath } from "../paths";
 import { isBadVersion } from "./binaryValidator";
+import { Logger } from "../../utils/logger";
 
 export default function handleActiveFile(): string | null {
   try {
@@ -17,7 +18,7 @@ export default function handleActiveFile(): string | null {
       }
     }
   } catch (e) {
-    console.error(
+    Logger.error(
       "Error handling .active file. Falling back to semver sorting",
       e
     );

src/binary/binaryFetcher/binaryValidator.ts

@@ -1,6 +1,7 @@
 import * as semver from "semver";
 import { asyncExists } from "../../utils/file.utils";
 import { runProcess } from "../runProcess";
+import { Logger } from "../../utils/logger";
 
 // A patch to skip this specific version, because of a critical issue in the version
 const BAD_VERSION = "4.0.47";
@@ -28,7 +29,7 @@ export default async function isValidBinary(version: string): Promise<boolean> {
 
   return new Promise((resolve) => {
     setTimeout(() => {
-      console.error(`validating ${version} timeout`);
+      Logger.error(`validating ${version} timeout`);
       resolve(false);
     }, TWO_SECONDS_TIMEOUT);
 

src/binary/binaryFetcher/existingVersionHandler.ts

@@ -3,6 +3,7 @@ import sortBySemver from "../../utils/semver.utils";
 import { asyncFind } from "../../utils/utils";
 import isValidBinary, { isBadVersion } from "./binaryValidator";
 import { getRootPath, versionPath } from "../paths";
+import { Logger } from "../../utils/logger";
 
 export default async function handleExistingVersion(): Promise<string | null> {
   try {
@@ -13,7 +14,7 @@ export default async function handleExistingVersion(): Promise<string | null> {
     const versions = sortBySemver(validVersions).map(versionPath);
     return await asyncFind(versions, isValidBinary);
   } catch (e) {
-    console.error(
+    Logger.error(
       "Error handling existing version. Falling back to downloading",
       e
     );

src/binary/requests/fileMetadata.ts

@@ -1,10 +1,11 @@
-/* eslint-disable 
-     @typescript-eslint/no-explicit-any, 
-     @typescript-eslint/no-unsafe-assignment, 
-     @typescript-eslint/no-unsafe-member-access, 
+/* eslint-disable
+     @typescript-eslint/no-explicit-any,
+     @typescript-eslint/no-unsafe-assignment,
+     @typescript-eslint/no-unsafe-member-access,
      @typescript-eslint/no-unsafe-return
 */
 
+import { Logger } from "../../utils/logger";
 import { tabNineProcess } from "./requests";
 
 export async function getFileMetadata(path: string): Promise<unknown> {
@@ -13,7 +14,7 @@ export async function getFileMetadata(path: string): Promise<unknown> {
   });
 
   if (response.error) {
-    console.error("Failed to get file metadata", response);
+    Logger.error("Failed to get file metadata", response);
     return null;
   }
 

src/binary/requests/notifyWorkspaceChanged.ts

@@ -1,3 +1,4 @@
+import { Logger } from "../../utils/logger";
 import { tabNineProcess } from "./requests";
 
 interface NotifyWorkspaceChangedRequest {
@@ -16,7 +17,7 @@ function notifyWorkspaceChanged(
       },
       5000
     )
-    .catch(console.error);
+    .catch((e) => Logger.error(e));
 }
 
 export default notifyWorkspaceChanged;

src/binary/requests/requests.ts

@@ -3,6 +3,7 @@ import CompletionOrigin from "../../CompletionOrigin";
 import Binary from "../Binary";
 import { State } from "../state";
 import { StateType } from "../../globals/consts";
+import { Logger } from "../../utils/logger";
 
 export const tabNineProcess = new Binary();
 
@@ -134,7 +135,7 @@ export function deactivate(): Promise<unknown> {
     return tabNineProcess.request({ Deactivate: {} });
   }
 
-  console.error("No TabNine process");
+  Logger.error("No TabNine process");
 
   return Promise.resolve(null);
 }
@@ -170,7 +171,7 @@ export async function getCapabilities(): Promise<
 
     return result;
   } catch (error) {
-    console.error(error);
+    Logger.error(error);
 
     return { enabled_features: [] };
   }

src/cloudEnvs/setupCloudState.ts

@@ -2,6 +2,7 @@ import { promises as fsPromises } from "fs";
 import { ExtensionContext } from "vscode";
 import * as consts from "./consts";
 import { ensureExists, watch } from "../utils/file.utils";
+import { Logger } from "../utils/logger";
 
 export default async function state(context: ExtensionContext): Promise<void> {
   await ensureExists(consts.TABNINE_CONFIG_DIR);
@@ -28,15 +29,15 @@ async function loadStateFromCloudEnv(context: ExtensionContext): Promise<void> {
     await fsPromises
       .writeFile(consts.TABNINE_TOKEN_FILE_PATH, tabnineToken)
       .catch((e) => {
-        console.error("Error occurred while trying to load Tabnine token", e);
+        Logger.error("Error occurred while trying to load Tabnine token", e);
       });
   }
 
   if (tabnineConfig)
     await fsPromises
       .writeFile(consts.TABNINE_CONFIG_FILE_PATH, tabnineConfig)
       .catch((e) => {
-        console.error("Error occurred while trying to load Tabnine config", e);
+        Logger.error("Error occurred while trying to load Tabnine config", e);
       });
 }
 
@@ -59,7 +60,7 @@ function persistStateToCloudEnv(context: ExtensionContext): void {
               )
             )
             .catch((e) => {
-              console.error(
+              Logger.error(
                 "Error occurred while trying to persist Tabnine token",
                 e
               );
@@ -76,7 +77,7 @@ function persistStateToCloudEnv(context: ExtensionContext): void {
             )
           )
           .catch((e) => {
-            console.error(
+            Logger.error(
               "Error occurred while trying to persist Tabnine config",
               e
             );

src/enterprise/statusBar/StatusBar.ts

@@ -17,6 +17,7 @@ import {
   CONGRATS_MESSAGE_SHOWN_KEY,
 } from "../../globals/consts";
 import getUserInfo, { UserInfo } from "../requests/UserInfo";
+import { Logger } from "../../utils/logger";
 
 export class StatusBar implements Disposable {
   private item: StatusItem;
@@ -40,7 +41,8 @@ export class StatusBar implements Disposable {
     );
     this.setDefaultStatus();
 
-    this.setServerRequired().catch(console.error);
+    // eslint-disable-next-line @typescript-eslint/unbound-method
+    this.setServerRequired().catch(Logger.error);
   }
 
   private async setServerRequired() {
@@ -81,7 +83,7 @@ export class StatusBar implements Disposable {
   }
 
   private setGenericError(error: Error) {
-    console.error(error);
+    Logger.error(error);
     this.item.setError("Something went wrong");
     this.item.setCommand(StatusState.OpenLogs);
   }

src/enterprise/update/serverUrl.ts

@@ -3,6 +3,7 @@ import {
   SELF_HOSTED_SERVER_CONFIGURATION,
   TABNINE_HOST_CONFIGURATION,
 } from "../consts";
+import { Logger } from "../../utils/logger";
 
 export default function serverUrl(): string | undefined {
   const oldUrl = workspace
@@ -22,7 +23,7 @@ export function validateUrl(url: string | undefined): boolean {
     Uri.parse(url || "", true);
     return true;
   } catch (error) {
-    console.error("Tabnine updater - wrong server url");
+    Logger.error("Tabnine updater - wrong server url");
     return false;
   }
 }

src/enterprise/update/updateAndReload.ts

@@ -16,7 +16,7 @@ export default async function updateAndReload(serverUrl: string) {
       Logger.info("Tabnine updater - nothing to update");
     }
   } catch (e) {
-    console.error("Failed to update Tabnine plugin", e);
+    Logger.error("Failed to update Tabnine plugin");
     void vscode.window
       .showErrorMessage(
         "Failed to update Tabnine, check Tabnine log output for more details",

src/globals/proposedAPI.ts

@@ -3,6 +3,7 @@ import * as vscode from "vscode";
 import * as path from "path";
 import * as os from "os";
 import showMessage from "../preRelease/messages";
+import { Logger } from "../utils/logger";
 
 const EXTENSION_ID = "TabNine.tabnine-vscode";
 const ARGV_FILE_NAME = "argv.json";
@@ -16,7 +17,7 @@ const ENABLE_PROPOSED_API = [
 
 export default async function enableProposed(): Promise<boolean> {
   return handleProposed().catch((error) => {
-    console.error("failed to enable proposedAPI", error);
+    Logger.error(`failed to enable proposedAPI ${error}`);
     return false;
   });
 }

src/handleUninstall.ts

@@ -2,6 +2,7 @@ import * as fs from "fs";
 import * as path from "path";
 import { Disposable } from "vscode";
 import tabnineExtensionProperties from "./globals/tabnineExtensionProperties";
+import { Logger } from "./utils/logger";
 
 export default function handleUninstall(
   onUninstall: () => Promise<unknown>
@@ -26,12 +27,12 @@ export default function handleUninstall(
       if (isFileExists(curr) && isModified(curr, prev)) {
         fs.readFile(uninstalledPath, (err, uninstalled) => {
           if (err) {
-            console.error("failed to read .obsolete file:", err);
+            Logger.error("failed to read .obsolete file:", err);
             throw err;
           }
           fs.readdir(extensionsPath, (error, files: string[]) => {
             if (error) {
-              console.error(
+              Logger.error(
                 `failed to read ${extensionsPath} directory:`,
                 error
               );
@@ -48,7 +49,7 @@ export default function handleUninstall(
                   fs.unwatchFile(uninstalledPath, watchFileHandler);
                 })
                 .catch((e) => {
-                  console.error("failed to report uninstall:", e);
+                  Logger.error("failed to report uninstall:", e);
                 });
             }
           });
@@ -60,7 +61,7 @@ export default function handleUninstall(
       fs.watchFile(uninstalledPath, watchFileHandler)
     );
   } catch (error) {
-    console.error("failed to invoke uninstall:", error);
+    Logger.error("failed to invoke uninstall:", error);
   }
   return new Disposable(() => {});
 }

src/notificationsWidget/notificationsWidgetWebview.ts

@@ -3,6 +3,7 @@ import { Capability } from "../capabilities/capabilities";
 import { fireEvent } from "../binary/requests/requests";
 import { StateType } from "../globals/consts";
 import registerWidgetWebviewProvider from "../widgetWebview/widgetWebview";
+import { Logger } from "../utils/logger";
 
 const LOADED_NOTIFICATIONS_WIDGET = "loaded-notificaitons-widget-as-webview";
 
@@ -18,7 +19,7 @@ export default function registerNotificationsWebviewProvider(
     onWebviewLoaded: () => {
       void fireEvent({
         name: LOADED_NOTIFICATIONS_WIDGET,
-      }).catch(console.error);
+      }).catch((e) => Logger.error(e));
     },
   });
 }

src/preRelease/installer.ts

@@ -20,6 +20,7 @@ import {
 } from "./versions";
 import { ExtensionContext, GitHubReleaseResponse } from "./types";
 import { Capability, isCapabilityEnabled } from "../capabilities/capabilities";
+import { Logger } from "../utils/logger";
 
 const badVersion = "9999.9999.9999";
 
@@ -50,7 +51,7 @@ export default async function handlePreReleaseChannels(
       }
     }
   } catch (e) {
-    console.error(e);
+    Logger.error(e);
   }
 }