Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Add triggers to the protocol. #143

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Add triggers to the protocol. #143

merged 1 commit into from
Apr 28, 2017

Conversation

mwkmwkmwk
Copy link
Contributor

Protocol changes only - no implementation yet.

@mwkmwkmwk mwkmwkmwk force-pushed the wip/mwk/trigger-proto branch from 5b5f595 to d8a4ea8 Compare April 10, 2017 09:19
@mwkmwkmwk mwkmwkmwk force-pushed the wip/mwk/db-tracker branch 2 times, most recently from de0178f to 508a093 Compare April 12, 2017 10:31
@mwkmwkmwk mwkmwkmwk force-pushed the wip/mwk/trigger-proto branch from d8a4ea8 to 596f1ce Compare April 12, 2017 10:33
@mwkmwkmwk mwkmwkmwk changed the base branch from wip/mwk/db-tracker to master April 12, 2017 10:33
return res

def get_trigger(self, id, key):
return self._get_from_node(id, lambda node: self._get_trigger(node, key))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pep8 fails :*(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@mwkmwkmwk mwkmwkmwk force-pushed the wip/mwk/trigger-proto branch 2 times, most recently from 2cf24d7 to a88dfe3 Compare April 20, 2017 10:08
@altran01
Copy link
Contributor

TriggerState isn't generated in C++ (in PR #159 I'm changing code generation to improve it a bit - including no need to explicitly specify EnumModels to generate).

@mwkmwkmwk mwkmwkmwk force-pushed the wip/mwk/trigger-proto branch from a88dfe3 to f15a520 Compare April 27, 2017 11:56
@mwkmwkmwk
Copy link
Contributor Author

Fixed.

@mwkmwkmwk mwkmwkmwk force-pushed the wip/mwk/trigger-proto branch from f15a520 to d5b7695 Compare April 28, 2017 10:56
@mwkmwkmwk mwkmwkmwk merged commit d5b7695 into master Apr 28, 2017
@mwkmwkmwk mwkmwkmwk deleted the wip/mwk/trigger-proto branch April 28, 2017 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants