Added a method for storing and setting ship attributes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to load a specific ship per level with customized features
Jon-Cavaliere
requested review from
jaythomas,
wyatt-herkamp and
SuperShadowPlay
Copy and paste error showed index 5 three times
Changed the shape points on ship_purple (Index 7) because they were offset on the Y-Axis from the bottom far too much
I set it to 0.0001 for experimenting. I reverted it back to its orginial value with the commit
|
Other than my few comments, this looks great. Maybe at one point we may want to make a menu that loads a specific ship, but for now I think this is perfect. |
services/textures.lua
Outdated
| @@ -4,7 +4,18 @@ textures.load = function() | |||
| textures.spaceship = love.graphics.newImage("/assets/sprites/ship.png") | |||
| textures.star = love.graphics.newImage("/assets/sprites/star.png") | |||
| textures.planet = love.graphics.newImage('assets/sprites/planet.png') | |||
|
|
|||
| -- Wyatt's Beautiful spedboost | |||
|
|
|
Thank you for reminding me. I meant to remove that asset. It was for testing purposes only. Will fix in a future commit |
jaythomas
reviewed
Feb 2, 2022
Maps that don't specify a ship_type will default to Trevor's OG ship
#Conflicts ## player.lua ## textures.lua
Renamed the following: ship_ship_2 is now ship_2 ship_shuttle_no_boosters is now ship_shuttle_2 noPlanet.tmx is now no_planets.tmx All references are updated in the code.
- Changed no_planets.tmx default ship to ship_big
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to load a specific ship per level with customized features
in Tiled custom properties - integer shipType sets which index to use when spawning the player's ship.