Removed home page special permissions #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e11sy
approved these changes
Jan 27, 2025
neSpecc
approved these changes
Jan 27, 2025
|
Thanks, @devnull-1337. Nice job |
|
@neSpecc Appretiate it! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Home tab was integrated in tabbar for user to have ability to go to the home page (it is unclosable) when we did not have logo
Now we have logo to go to the home page, so home tab should not exist.
Solution:
As describe in issue #291, we will be removing home tab from the navbar and its special conditions.
Resolves #291