Avoid hardcoded emails on notification listener.

src/main/java/es/urjc/code/dad/mail/batch/BatchConfiguration.java

@@ -40,6 +40,9 @@ public class BatchConfiguration {
 	@Value("${codeurjc.batch.attachment}")
 	private String attachment;
 
+	@Value("${codeurjc.batch.notifications.email}")
+	private String email;
+
 	// tag::readerwriterprocessor[]
 	@Bean
 	public FlatFileItemReader<Student> reader() {
@@ -73,7 +76,7 @@ public MailBatchItemWriter writer() {
 
     @Bean
     public JobExecutionListener listener() {
-        return new JobCompletionNotificationListener();
+        return new JobCompletionNotificationListener(email);
     }
 
     // end::listener[]

src/main/java/es/urjc/code/dad/mail/batch/JobCompletionNotificationListener.java

@@ -3,6 +3,7 @@
 import org.springframework.batch.core.JobExecution;
 import org.springframework.batch.core.listener.JobExecutionListenerSupport;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.mail.SimpleMailMessage;
 import org.springframework.mail.javamail.JavaMailSender;
 
@@ -11,14 +12,20 @@ public class JobCompletionNotificationListener extends JobExecutionListenerSuppo
 	@Autowired
 	private JavaMailSender mailSender;
 
+	private String notificationEmail;
+
+	public JobCompletionNotificationListener(String notificationEmail) {
+		this.notificationEmail = notificationEmail;
+	}
+
 	@Override
 	public void afterJob(JobExecution jobExecution) {
 
 		SimpleMailMessage message = new SimpleMailMessage();
 
 		message.setSubject("Job completion");
-		message.setFrom("[email protected]");
-		message.setTo("[email protected]");
+		message.setFrom(notificationEmail);
+		message.setTo(notificationEmail);
 		message.setText("Job completed with " + jobExecution.getExitStatus());
 
 		mailSender.send(message);
@@ -30,8 +37,8 @@ public void beforeJob(JobExecution jobExecution) {
 		SimpleMailMessage message = new SimpleMailMessage();
 
 		message.setSubject("Job started");
-		message.setFrom("[email protected]");
-		message.setTo("[email protected]");
+		message.setFrom(notificationEmail);
+		message.setTo(notificationEmail);
 		message.setText("Job started");
 
 		mailSender.send(message);

src/main/java/es/urjc/code/dad/mail/batch/StudentItemProcessor.java

@@ -44,6 +44,7 @@ public MimeMessage process(Student student) throws Exception {
 		model.put("code", student.getCode());
 		helper.setFrom(sender);
 		helper.setTo(student.getEmail());
+		helper.setCc(sender);
 		helper.setSubject(VelocityEngineUtils.mergeTemplateIntoString(engine, "email-subject.vm", "UTF-8", model));
 		helper.setText(VelocityEngineUtils.mergeTemplateIntoString(engine, "email-body.vm", "UTF-8", model));
 

src/main/resources/application.properties

@@ -14,3 +14,6 @@ spring.mail.properties.mail.smtp.starttls.enable=true
 #codeurjc.batch.data=
 # Path to attachment data (this file will be attached to all emails sent)
 #codeurjc.batch.attachment=
+
+# email for job notifications
+# codeurjc.batch.notifications.email=