add custom style #75
Closed
add custom style #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jahss , thanks for contributing. This specific feature is something we have debated about adding. It's difficult to decide where the line should be drawn regarding this kind of customization in the admin (Adding CSS classes > Adding raw CSS styles > A full on CSS editor similar to WordPress, etc.). So we're going to continue debating this before deciding whether or not to merge this in. Good job though, this PR looks pretty complete. |
|
Thanks for the effort in making this pull request. I think we will hold off on this feature for now. But we might reconsider in a future release once we begin work on themes per #44 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.