Epilogue with RELU #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aacostadiaz
force-pushed
the
intel-relu
branch
2 times, most recently
from
3c08963 to
31434ee
Compare
| fusion::LinearCombination<ElementOutput_, ElementCompute_, ElementSource_, ElementScalar_, RoundStyle_>, | ||
| CtaTileShapeMNK_, | ||
| EpilogueTile_ | ||
| > : Sm90LinearCombination<typename cutlass::detail::get_unpacked_element_type<ElementOutput_>::type, ElementCompute_, ElementSource_, ElementScalar_, RoundStyle_> { |
There was a problem hiding this comment.
That's the name of the fusion operator for linear combination in Cutlass 3. Unfortunately, that's the naming convention used for almost all the visitor fusions in Cutlass 3, even though most of them are generic and can be used on other GPUs.
If, for whatever reason, we need a linear combination that is specific for Intel PVC, we can just replace Sm90LinearCombination with the specific implementation (same apply for all the visitor fusions).
|
Could be useful to post the compare link for these incremental PRs. In this case: muhammad-tanvir-1211/cutlass-fork@intel-epilogue...aacostadiaz:cutlass-fork:intel-relu |
aacostadiaz
force-pushed
the
intel-relu
branch
3 times, most recently
from
1a47f2d to
c361ed1
Compare
aacostadiaz
force-pushed
the
sycl-develop
branch
from
039211b to
8f3bd67
Compare
mehdi-goli
approved these changes
Jul 16, 2024
aacostadiaz
added a commit
to aacostadiaz/cutlass-fork
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the EVT for relu.