Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with size operator call in tensor_foreach.h file #81

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix bug with size operator call in tensor_foreach.h file #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tools/util/include/cutlass/util/reference/device/tensor_foreach.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ struct TensorForEach {
#if defined (CUTLASS_ENABLE_SYCL)
// TODO: query the queue for block size
block_size = 128;
grid_size = (size(size) + block_size - 1) / block_size;
grid_size = (size.product() + block_size - 1) / block_size;
int sm_count = KernelHardwareInfo::query_device_multiprocessor_count();
grid_size = grid_size > sm_count / 2 ? sm_count / 2 : grid_size;
#else
// if grid_size or block_size are zero, query occupancy using the CUDA Occupancy API
cudaError_t result = cudaOccupancyMaxPotentialBlockSize(
Expand All @@ -75,7 +77,7 @@ struct TensorForEach {
#if defined(CUTLASS_ENABLE_SYCL)
const auto sycl_block = syclcompat::dim3(block_size, 1, 1);
const auto sycl_grid = syclcompat::dim3(grid_size, 1, 1);
syclcompat::launch<kernel::TensorForEach<Func, Rank, Params>>(sycl_grid, sycl_block, 0, size, params);
syclcompat::launch<kernel::TensorForEach<Func, Rank, Params>>(sycl_grid, sycl_block, size, params);
#else
dim3 grid(grid_size, 1, 1);
dim3 block(block_size, 1, 1);
Expand Down Expand Up @@ -103,7 +105,7 @@ struct TensorDiagonalForEach {
#if defined(CUTLASS_ENABLE_SYCL)
const auto sycl_block = syclcompat::dim3(block_size, 1, 1);
const auto sycl_grid = syclcompat::dim3((end - start + block_size - 1) / block_size, 1, 1);
syclcompat::launch<kernel::TensorDiagonalForEach<Func, Rank, Params>>(sycl_grid, sycl_block, 0, size, params, start, end);
syclcompat::launch<kernel::TensorDiagonalForEach<Func, Rank, Params>>(sycl_grid, sycl_block, size, params, start, end);
#else
dim3 block(block_size, 1, 1);
dim3 grid((end - start + block_size - 1) / block_size, 1, 1);
Expand Down Expand Up @@ -153,7 +155,7 @@ struct BlockForEach {
#if defined(CUTLASS_ENABLE_SYCL)
const auto sycl_block = syclcompat::dim3(block_size, 1, 1);
const auto sycl_grid = syclcompat::dim3(grid_size, 1, 1);
syclcompat::launch<kernel::BlockForEach<Element, Func>>(sycl_grid, sycl_block, 0, ptr, capacity, params);
syclcompat::launch<kernel::BlockForEach<Element, Func>>(sycl_grid, sycl_block, ptr, capacity, params);
#else
dim3 grid(grid_size, 1, 1);
dim3 block(block_size, 1, 1);
Expand Down
Loading