Update syclcompat launch for PVC #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-tanvir-1211
approved these changes
Jul 30, 2024
Reverting as the same changes come in as a part of codeplaysoftware#104 This reverts commit bbb4def.
aacostadiaz
reviewed
Jul 31, 2024
| @@ -60,6 +60,7 @@ | |||
|
|
|||
| #if defined(CUTLASS_ENABLE_SYCL) | |||
| #include "cutlass/util/sycl_event_manager.hpp" | |||
| #include <syclcompat/syclcompat.hpp> | |||
There was a problem hiding this comment.
Why is this needed? The include for syclcompat is already added via cutlass/cutlass.h
There was a problem hiding this comment.
Oh yes, that's true.
Removed in 7592346
mehdi-goli
approved these changes
Aug 1, 2024
aacostadiaz
pushed a commit
to aacostadiaz/cutlass-fork
that referenced
this pull request
Aug 6, 2024
intel/llvm#14441 replaced the experimental launch interfaces for requesting a particular sub-group size with a launch with generic launch properties. This PR makes the required changes on our side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel/llvm#14441 replaced the experimental launch interfaces for requesting a particular sub-group size with a launch with generic launch properties. This PR makes the required changes on our side.