Upgrade base Ubuntu image to 16.04 #47
Conversation
This is in preparation for adding support for PHP 7 stack.
|
My plan is to next upgrade php/ubuntu/Dockerfile to include PHP 7 instead of 5. Please let me know if this is OK or if you'd prefer another approach (e.g. I can make a copy of both images in order to preserve older versions). |
This includes a temp change of the base image, to base it on an upgraded version of ubuntu_jre image (16.04). This is awaiting a resolution of PR codenvy-legacy#47 Apart from just specifying new package versions this change includes: - removal of mhash package (included in PHP by default now) - removal of granting privileges to root mysql user; this causes an error in the new version (no such user) as the root user is now @localhost and includes all privileges already
|
@eivantsov @garagatyi - will need to comment. All of our images are derived from the base image. We generally want to move everything over to alpine due to the size optimization that comes from that. We are focused on stability of the images and overall size for the end user. |
|
@gimoh - thansk for working to make a contribution - it's valued. |
|
What do you think would be the best approach to bring PHP7 support in short term? I'm happy enough to base it on an alpine base, although currently I only see alpine_jdk8, are you planning on using that as base or creating another alpine_jre? Regarding alpine and space savings, I totally agree with the principle, but I think this has most impact when creating microservice images, I'm not sure how significant the space savings will be when you install the full stack (e.g. JRE, Apache, PHP, MySQL, etc.) into one image. Unless you are planning adopting "the docker way" to workspace images and have each service in separate containers? |
|
We will need @eivantsov and @garagatyi to comment a bit on the proposed best path forward here is - should we just merge this PR as is , or should we offer some pointers on how we are evolving our images towards alpine so that @gimoh can get PHP7 added? |
|
Usually Eugene is working on image life cycle, so I would say it is up to him to decide which way is preferred. |
|
@gimoh why don't you issue a PR for a php7 image that uses ubuntu 16.04 as a base image? |
|
@eivantsov well, at the moment there is no codenvy base image (i.e. the base with JRE, git, SSH, etc. for workspace agent) based off ubuntu 16.04 but instead of updating ubuntu_jre, I can take a copy of it (say ubuntu16_jre) and base the PHP image on that? |
This is in preparation for adding support for PHP 7 stack.