Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned the contact component #158

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

dikshashukla455
Copy link
Contributor

Pull Request Template

Description

I have changed the styles of the contact card (the color of the card, added the box shadow, and added the hover effect on the card.).I have added some headings in the contact form for enhancing the user's understandability and changed some styles in the form.

Fixes #129

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

How Has This Been Tested?

  1. Go to the website
  2. Click on the contact link which is present in the navbar
  3. See the expected output

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code
  • I have signed the commit message to agree to the Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@dikshashukla455
Copy link
Contributor Author

Greetings @padmajabhol, I solved the conflicts. Kindly review it. Thank You.

@padmajabhol padmajabhol self-requested a review May 11, 2022 14:19
Copy link
Member

@padmajabhol padmajabhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you center the "Contact Us" heading to maintain uniformity?

@@ -130,6 +130,8 @@ function Contact(){
</Row>
<hr />
<Row>
<h2>Send us a message</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could look better if you center this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will do that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @padmajabhol, I have done it as per your requirements. Kindly review it. Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted a comment by mistake, sorry about that 😅

Copy link
Contributor Author

@dikshashukla455 dikshashukla455 May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR good? @padmajabhol or any other changes should be done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this should be good to go, thanks!

@codeisscience codeisscience deleted a comment from dikshashukla455 May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesigning the contact page
2 participants