Bar mobile #35
Merged
Bar mobile #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d each column element that was distorting the bar chart on small screens
… margin and expand the width of the cards
…to expand the viewing width of the charts without cutting off the y-axis title
… so fixed an error that was happening with 'new Date' where the new date value would revert to the date prior
joel-oe-lacey
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Thanks for adding those changes @javan-pohl, the colors are definitely a lot more visible on the Stacked Bar. Regarding the package-lock.json, this project uses Yarn, so that's why it was showing up as whole new file.
They recently changed the endpoint paths which requires a quick URL fix, I'm adding that in here, so I'll remove the package-lock.json while I'm at it. Also as I had changes I was putting in for the daily snapshot, I'll throw those in here to consolidate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request fixes issues related to the StackedBarPlot not displaying correctly on mobile devices, specifically that the bars become transparent and the x-axis date values start to overlap each other and become unreadable at mobile width display resolutions (tested at ~400px). Implemented fixes include changing the stroke (border on SVG shapes) in frameProps[style] to "none", changing the date format of the x-axis tick labels from July 1, 2020 to 7/1 and reducing their fontsize from 12 to 11, and changing various paddings/margins/widths in CSS .
Where should the reviewer start?
StackedBarPlot.js
How should this be manually tested?
View the 'tested' page on varying resolutions, from normal desktop width down to ~400px.
Any background context you want to provide?
No. I think I've covered everything
What are the relevant tickets?
#34
Questions:
Please let me know if there's anything I can do to improve workflow or the code.