Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing account IDs to staging and production credentials #5325

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mrotondo
Copy link
Contributor

@mrotondo mrotondo commented Jan 8, 2025

Is PM acceptance required? (delete one)

  • No - merge after code review approval

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • We store account IDs for each state that is used when making requests to the DF state export-return API
  • These account IDs are consistent across all our environments
  • For some reason, the NC account ID was missing from the staging credentials and the NJ account ID was missing from the production credentials. These are added (just by copying them from other environments) in this PR

How to test?

  • This should result in our being able to make successful requests to the DF state API for NJ in production

Copy link

github-actions bot commented Jan 8, 2025

Heroku app: https://gyr-review-app-5325-2521daf43277.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5325 (optionally add --tail)

@mrotondo mrotondo merged commit 57839e6 into main Jan 8, 2025
7 checks passed
@mrotondo mrotondo deleted the make-state-api-account-ids-consistent branch January 8, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants