Code

Nj 125 income editing#5288

Code

Open

mluedke2 wants to merge 72 commits intomaincodeforamerica/vita-min:mainfrom nj-125-income-editingcodeforamerica/vita-min:nj-125-income-editingCopy head branch name to clipboard

+391-124

Commits

Commits on Dec 17, 2024

• work in progress - comments on relevant lines

  mluedke2

  committed
  be6ee8c

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  c4b0a65

• one way to hide the unemployment box in nj

  mluedke2

  committed
  b04f37a

• use mailing state instead

  mluedke2

  committed
  aaaa000

• hide ssa-1099 if nj as well

  mluedke2

  committed
  46f7b6d

Commits on Dec 18, 2024

• only show income review if there is something to review

  mluedke2

  committed
  8848c80

• share display condition logic between controller and erb

  mluedke2

  committed
  026f17b

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  2d736b0

Commits on Dec 19, 2024

• for now just check for state is nj

  mluedke2

  committed
  89fcc1a

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  bf0927f

• remove comment for out of scope

  mluedke2

  committed
  60e06ab

• remove extra comment

  mluedke2

  committed
  505c8a8

• add e2e tests for income review visual changes

  mluedke2

  committed
  37bdf9c

• remove unused imports

  mluedke2

  committed
  648e1ae

Commits on Dec 20, 2024

• update lucky w2

  mluedke2

  committed
  a74cca3

• nj-specific content

  mluedke2

  committed
  c1192ca

• dry and condition styling

  mluedke2

  committed
  b0ddea4

• edit text for box14

  mluedke2

  committed
  850a75d

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  f8465ab

• update xml for box 14

  mluedke2

  committed
  1b36583

Commits on Dec 23, 2024

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  71bd8d5

• sync es

  mluedke2

  committed
  1c6ba7d

• conform to new format without slashes

  mluedke2

  committed
  5ac1833

• expectations for w2 editing

  mluedke2

  committed
  fc59a55

• proper test for assigning box 14 values

  mluedke2

  committed
  496b44f

• update more syntax for the no-slash format

  mluedke2

  committed
  609969e

• don't use shared tests for nj since it's tested separately

  mluedke2

  committed
  d23cc09

• missing key in es

  mluedke2

  committed
  7bb59ea

• normalize strings

  mluedke2

  committed
  34db50e

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  2826eda

• don't catch on conditional strings for unused test

  mluedke2

  committed
  ea26a0c

• rearrange translation string keys to not need to add to ignore list

  mluedke2

  committed
  52a2faf

• fix syntax

  mluedke2

  committed
  fd8644f

Commits on Dec 24, 2024

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  92cc4ee

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  d8ba042

• remove unneeded p

  mluedke2

  committed
  57ceb03

Commits on Dec 26, 2024

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  741c76c

• overwrite in model getter instead of just in controller for form, calculate using just one field

  mluedke2

  committed
  0bdbedf

• refactor to use one UI_MAX constant, and a method name that explicitly is named overwrite

  mluedke2

  committed
  471d383

• fix one of the failing tests

  mluedke2

  committed
  2876f29

Commits on Dec 27, 2024

• fix field name

  mluedke2

  committed
  c28f4cb

• partially undo renaming constants - still keep overwrite function name

  mluedke2

  committed
  a857576

• use without slashes or underscores since that is XML format

  mluedke2

  committed
  e52ac21

Commits on Dec 30, 2024

• work in progress - roll back to underscores

  mluedke2

  committed
  341250b

• field name

  mluedke2

  committed
  aaf6fa3

• use override for ui fields

  mluedke2

  committed
  1c199d7

• remove two nj checks

  mluedke2

  committed
  b3b80d9

• remove another nj-specific check

  mluedke2

  committed
  5e6ce7e

• fix i18n health hint

  mluedke2

  committed
  92dc749

• remove nj-specific key

  mluedke2

  committed
  62f04eb

• full i18n key needed for existence check

  mluedke2

  committed
  4da0204

• proper current_state_code

  mluedke2

  committed
  de323eb

Commits on Dec 31, 2024

• allow nj to reuse existing test again by making one part conditional

  mluedke2

  committed
  72ad66c

• edit zeus box 14 and refactor income edit e2e test to prepare for error message tests

  mluedke2

  committed
  eb3da14

• adjust expectations to match new xml

  mluedke2

  committed
  0b8b26e

• validation errors when value too high

  mluedke2

  committed
  dc0bdc3

• remove quotes from ui strings

  mluedke2

  committed
  bf0d899

• remove unneeded comments

  mluedke2

  committed
  b939fb1

Commits on Jan 2, 2025

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  5745774

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  bd6b566

• allow imports to happen without box14 validation

  mluedke2

  committed
  3b769dd

Commits on Jan 3, 2025

• remove non-supported box 14 values from xml

  mluedke2

  committed
  ed9ada7

• test for box 14 validation in w2 editing screen

  mluedke2

  committed
  370ef24

• validate box14 on income review too

  mluedke2

  committed
  106ccf0

• only remove specific desc to not break other state tests

  mluedke2

  committed
  dd775ab

• leave hc_wd out of 2450 and use overwrite there too

  mluedke2

  committed
  f264b7e

• tests on model for validation

  mluedke2

  committed
  071764d

Commits on Jan 6, 2025

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  8b8a794

Commits on Jan 7, 2025

• Merge branch 'main' into nj-125-income-editing

  Show description for df54a83
  mluedke2

  committed
  df54a83

• simplify syntax

  mluedke2

  committed
  6f409c9

• Merge branch 'main' into nj-125-income-editing

  mluedke2

  committed
  c010c6d

Commits on Jan 8, 2025

• use lambdas instead of separate getter

  mluedke2

  committed
  f33f5e5