[CCAP-571] - set earliest childcare start date in flow #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analoo
commented
Jan 7, 2025
| DateTimeFormatter formatter) { | ||
| if (earliestCCAPStartDate.isBlank()) { | ||
| return childCCAPStartDate; | ||
| } |
There was a problem hiding this comment.
these methods moved to either the Verify date action or Date Utilities
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/org/ilgcc/app/submission/actions/UpdateEarliestCCAPStartDate.java
Fixed
Show fixed
Hide fixed
analoo
commented
Jan 7, 2025
| String formattedMonth = String.format("%02d", Integer.parseInt(month)); | ||
| String formattedDay = String.format("%02d", Integer.parseInt(day)); | ||
|
|
||
| return String.format("%s/%s/%s", |
There was a problem hiding this comment.
Now this method saves dates with leading zeros so no need to have an extra method that does that
analoo
force-pushed
the
CCAP-571-set-earliest-childcare-start-date-in-flow
branch
from
3d849cd to
7b2723f
Compare
analoo
commented
Jan 7, 2025
| return earliestDate.get().isBefore(childcareStartDate.get()) ? earliestCCAPStartDate : childCCAPStartDate; | ||
| } | ||
|
|
||
| private String addLeadingZerosToDateString(String dateStr) { |
There was a problem hiding this comment.
leading zeros are added when the date is set
analoo
changed the title
cram-cfa
approved these changes
Jan 7, 2025
analoo
commented
Jan 7, 2025
src/main/resources/flows-config.yaml
Outdated
| @@ -467,6 +467,7 @@ flow: | |||
| doc-upload-confirm: | |||
| nextScreens: null | |||
| children-delete: | |||
| onPostAction: UpdateEarliestCCAPStartDate | |||
There was a problem hiding this comment.
hm. could it be because the nextScreens is null? what happens if you put some random screen there for it to go... somewhere?
There was a problem hiding this comment.
That doesn't resolve it unfortunately
enyia21
approved these changes
Jan 7, 2025
…ixes typo in Save CCAP Start Date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
CCAP-571
✍️ Description
📷 Design reference
n/a
✅ Completion tasks