Add a test for going from a regular POST into a subflow #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spokenbird
commented
Oct 25, 2023
spokenbird
commented
- Adds a test to prevent regression with regards to c05abf3
spokenbird
commented
Oct 25, 2023
| @@ -9,8 +9,8 @@ | |||
| <main id="content" role="main" class="form-card spacing-above-35"> | |||
| <th:block | |||
| th:replace="~{fragments/cardHeader :: cardHeader(header='Subflow Page', subtext='This is a page within a subflow')}"/> | |||
| <!-- Test that the currentSubflowItem is passed in by the controller: --> | |||
| <div th:text="${currentSubflowItem.firstNameSubflow}"></div> | |||
There was a problem hiding this comment.
I'm not sure what this was doing exactly but firstNameSubflow was null and I couldn't figure out what would have been setting it in the first place.
There was a problem hiding this comment.
I wonder if that was debug that didn't get taken out?
There was a problem hiding this comment.
Should that div even be there? Not exactly sure what it's doing either.
There was a problem hiding this comment.
I think you might be right, I'll take it out all together.
There was a problem hiding this comment.
@spokenbird Did you decide to remove this?
|
@spokenbird, when your back, what's the status of this PR? Is is ready to be reviewed? |
cy-by
force-pushed
the
add-subflow-test
branch
from
b8efc53 to
63ad9b6
Compare
cy-by
force-pushed
the
add-subflow-test
branch
from
63ad9b6 to
7672bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.