Adds migration and column for doc_type_label and fixes virus scanning logic
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bseeger
changed the title
bseeger
force-pushed
the
add-type-to-user-file
branch
from
dfd6219 to
6001dfa
Compare
bseeger
changed the title
doc_type_label and fixes virus scanning logic
spokenbird
reviewed
Oct 30, 2023
spokenbird
reviewed
Oct 30, 2023
src/main/resources/db/migration/V2023.10.25.08.53.44__create_doc_type_label_for_user_files.sql
Show resolved
Hide resolved
spokenbird
reviewed
Oct 30, 2023
bseeger
force-pushed
the
add-type-to-user-file
branch
from
04460b4 to
010b2e1
Compare
cy-by
reviewed
Nov 1, 2023
|
One last comment and there's a conflict in |
Fixes an issue with virus scanning if using the noop scanner (would always say the files was scanned) Co-Authored-By: Lauren Kemperman; [email protected]
wouldn't run. This now makes sure there is a default value.
Co-Authored-By: Lauren Kemperman; [email protected]
Fixes a typo in the readme and adds a section about the dynamic fields. Co-Authored-By: Lauren Kemperman; [email protected]
Since the test db doesn't appear to be working correctly, this code is commented out until we figure out why the DB migrations aren't working well in test.
bseeger
force-pushed
the
add-type-to-user-file
branch
from
1aef6f9 to
4a2bc04
Compare
cy-by
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc_type_labeltouser_filestable.form-flow.uploads.default-doc-type-labelso one can set the default document type if they want.@DynamicFieldannotation and separates annotations from their validators (slight package reorg)truewhen scanning was turned off. The NoOpVirusScanner is used when the virus scanning is disabled, so it was marking the record inaccurately. We revamped the logic around this and made the check a little clearer.You can test this ticket out by using this branch in the LA Doc Uploader.