-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Legacy upload sender not working with extra args #574
Conversation
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this to work i think wherever you're calling send_upload_data, you have to pass the arguments as kwargs:
sending_result = sender.send_upload_data(
upload_data=upload_data,
commit_sha=commit_sha,
token=token,
env_vars=env_vars,
report_code=report_code,
upload_file_type=upload_file_type,
name=name,
branch=branch,
slug=slug,
pull_request_number=pull_request_number,
build_code=build_code,
build_url=build_url,
job_code=job_code,
flags=flags,
ci_service=ci_service,
git_service=git_service,
enterprise_url=enterprise_url,
parent_sha=parent_sha,
upload_coverage=upload_coverage,
args=args,
)
sender.send_upload_data pass arguments as kwargs
sending_result = UploadSender().send_upload_data( | ||
upload_collection, random_sha, random_token, upload_coverage=True, **named_upload_data | ||
upload_collection, | ||
random_sha, | ||
random_token, | ||
upload_coverage=True, | ||
**named_upload_data, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting caught this, unrelated to PR
These args are not used in legacy uploader:
report_code
upload_file_type
git_service
Added
**kwargs
ignore these and also ignore any other extra args being passed to the legacy upload sender.Fixes #572