Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better default file pattern for test results #379

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a894545) 96.02% compared to head (021fb79) 96.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          81       81           
  Lines        2816     2816           
=======================================
  Hits         2704     2704           
  Misses        112      112           
Flag Coverage Δ
python3.10 96.31% <ø> (ø)
python3.11 96.30% <ø> (ø)
python3.8 96.27% <ø> (ø)
python3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -36,7 +36,7 @@
]

test_results_files_patterns = [
"*junit*",
"*junit.xml",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ufffff, idk man, this looks like a heavy change, tread with caution

@joseph-sentry joseph-sentry merged commit 3662353 into main Feb 13, 2024
17 of 18 checks passed
@joseph-sentry joseph-sentry deleted the joseph/test-result-better-default branch February 13, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants