adding PR option to create-report command #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 80 80
Lines 2713 2715 +2
=======================================
+ Hits 2590 2592 +2
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dana-yaish
requested review from
matt-codecov,
scott-codecov and
giovanni-guidini
matt-codecov
previously approved these changes
Nov 9, 2023
Comment on lines
+52
to
+56
| headers = ( | ||
| {} | ||
| if not token and is_fork_pr(pull_request_number, decoded_slug, service) | ||
| else get_token_header_or_fail(token) | ||
| ) |
There was a problem hiding this comment.
super minor nit: when you merge, could you mention this extra little change in the commit message? just in case someone is reading through commit history searching for a bug or trying to learn how tokenless was implemented. something like adding PR option and tokenless logic to create-report command
dana-yaish
dismissed
matt-codecov’s stale review
The base branch was changed.
giovanni-guidini
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need the pr number for the PR API request to know if the command runs in a fork PR