check if the PR is a fork PR #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 95.39% 95.46% +0.06%
==========================================
Files 78 80 +2
Lines 2673 2713 +40
==========================================
+ Hits 2550 2590 +40
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dana-yaish
force-pushed
the
dana/identify-fork-prs
branch
2 times, most recently
from
9ddc2dd to
6802c70
Compare
dana-yaish
force-pushed
the
dana/identify-fork-prs
branch
from
6802c70 to
34dea1e
Compare
matt-codecov
previously approved these changes
Nov 8, 2023
codecov_cli/helpers/git.py
Outdated
| git_service = get_git_service(service) | ||
| if git_service: | ||
| pull_dict = git_service.get_pull_request(decoded_slug, pr_num) | ||
| if pull_dict and pull_dict["head"]["slug"] != decoded_slug: |
There was a problem hiding this comment.
do we need to decode the slug? if the PR API request gives us both the head and the base, we can just see if they're different?
if pull_dict and pull_dict["head"]["slug"] != pull_dict["base"]["slug"]:
There was a problem hiding this comment.
you're right we ca do it both ways, but we need to decode it since we need it in the API request to get the pull request
dana-yaish
force-pushed
the
dana/identify-fork-prs
branch
from
b5d0e5d to
0dfd717
Compare
matt-codecov
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR for tokenless upload and branch conflation bug fix where we check if the PR is a fork PR.
I'm not using any auth tokens as forked PRs are public for open source repos. And a forked repo made from a public upstream cannot change its visibility to private.
This PR implements getting PR info from github only, other providers are needed still, but pushing my code to get initial review
We'll need to add the fork PR check in each command we want to support tokenless for. For uploads we'll need to add it to create_commit, create_report and do_upload commands logic. But, create_report does not have reference to the PR number, which means we'll need to add it there.
codecov/engineering-team#733