chore: remove smart-open #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to add codecov-cli to getsentry/pypi. It was asked that we drop the smart-open dependency. I went back and checked that smart-open is really used for dealing with files in remote storage and decompressing things under-the-hood. We don't need any of that, and are well served by the default open function. So it's fine to drop it.
Codecov Report
@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 93.33% 95.39% +2.06%
==========================================
Files 75 78 +3
Lines 2670 2673 +3
Branches 314 0 -314
==========================================
+ Hits 2492 2550 +58
+ Misses 126 123 -3
+ Partials 52 0 -52
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
requested review from
joseph-sentry,
scott-codecov and
matt-codecov
joseph-sentry
approved these changes
Nov 6, 2023
scott-codecov
added a commit
that referenced
this pull request
Nov 15, 2023
* heads/main: simplify the ternary operator amend branch names to be forked-slug:branch-name we need the pr number for the PR API request to know if the command runs in a fork PR chore: Fix helper text in label analysis (#315) taking decoding slug out of is_fork_pr, cause it doesn't feel right to be there adding tests check if the PR is a fork PR chore: remove smart-open (#326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to add codecov-cli to getsentry/pypi.
It was asked that we drop the smart-open dependency.
I went back and checked that smart-open is really used for dealing with
files in remote storage and decompressing things under-the-hood.
We don't need any of that, and are well served by the default open function.
So it's fine to drop it.