feat: let users specify pytest command #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanni-guidini
requested review from
joseph-sentry,
matt-codecov and
scott-codecov
context: codecov/engineering-team#715 Apparently some users don't have a virtualenv or don't install packages globaly. In this case running `python -m pytest` doesn't work because pytest is not accessible to the global python. These changes let users specify a different command to run, so that they can tell the PytestStandardRunner where to find `pytest`. In terms of security it's not more dangerous than having a DAN runner, so should be ok.
giovanni-guidini
force-pushed
the
gio/pytest-cmd-prefix
branch
from
41375c6 to
04b0f34
Compare
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 95.52% 95.53% +0.01%
==========================================
Files 79 79
Lines 2747 2754 +7
==========================================
+ Hits 2624 2631 +7
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: codecov/engineering-team#715
Apparently some users don't have a virtualenv or don't install packages globaly.
In this case running
python -m pytestdoesn't work because pytest is not accessible to theglobal python.
These changes let users specify a different command to run, so that they can tell
the PytestStandardRunner where to find
pytest.In terms of security it's not more dangerous than having a DAN runner, so should be ok.