chore: Fix helper text in label analysis #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 95.39% 95.53% +0.13%
==========================================
Files 78 79 +1
Lines 2673 2753 +80
==========================================
+ Hits 2550 2630 +80
Misses 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Since the previous change to label analysis the help text was outdated. These changes fix it to be more accurate. Also removing the test for the help text because it's more annoying than it's helpful. It doesn't really _test_ anything, because the formatting is done by click
giovanni-guidini
force-pushed
the
gio/fix-ats-helper-text
branch
from
dfbb794 to
1f957a0
Compare
scott-codecov
approved these changes
Nov 3, 2023
scott-codecov
added a commit
that referenced
this pull request
Nov 15, 2023
* heads/main: simplify the ternary operator amend branch names to be forked-slug:branch-name we need the pr number for the PR API request to know if the command runs in a fork PR chore: Fix helper text in label analysis (#315) taking decoding slug out of is_fork_pr, cause it doesn't feel right to be there adding tests check if the PR is a fork PR chore: remove smart-open (#326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the previous change to label analysis the help text was outdated.
These changes fix it to be more accurate.
Also removing the test for the help text because it's more annoying than
it's helpful. It doesn't really test anything, because the formatting
is done by click