updates learning goals & rubric, comp -> reflection

.github/PULL_REQUEST_TEMPLATE

@@ -1,7 +1,8 @@
-# ride share
-Congratulations! You're submitting your assignment.
+# Assignment Submission: Ride Share
 
-## Comprehension Questions
+Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
+
+## Reflection
 
 |  Question 	|  Answer 	|
 |---	|---	|

README.md

@@ -10,11 +10,17 @@
 Rideshare Programs are systems that help people organize carpooling/vanpooling. Some popular on-demand rideshare apps, like Lyft and Uber, store and use data on riders, drivers, and trips, particularly data on when a trip happened, who was the driver, and who was the rider.
 
 ## Learning Goals
-- Logically order data into a nested data structure
-- Understand benefits of organizing data in a nested structure
-- Iterate through a nested data structure to return specific information
+
+- Create, read, and modify variables
+- Create and access arrays
+- Create and access hashes
+- Organize large amounts of related data into nested arrays and hashes
+- Access specific data within nested arrays and nested hashes
+- Iterate through a nested data structure using loops and/or Enumerable methods
+- Organize small pieces of code into methods, and call/invoke those methods
 
 ## Objective
+
 We will look at data of drivers of a rideshare service and their ride history. We want to be able to see how many rides each driver has given and how much money a driver has made.
 
 Currently, the data is stored in a [CSV file](https://en.wikipedia.org/wiki/Comma-separated_values). In this assignment, you should take this data and thoughtfully organize it into **one single** variable that is **one single** nested data structure. This nested data structure should use both arrays and hashes.
@@ -87,7 +93,7 @@ Once you're ready to submit this assignment (please mind the due date), you must
     - Check comments; do you need to delete unnecessary comments? Do you need to add some comments? (Most of the time, unless your code is particularly complex, you should have zero or few comments by the time of submission)
 1. **Most importantly:** make sure that your code is runnable. Run your code and make sure that simply running your program does not quit with Ruby error output. Your program should exit once everything is finished executing in an expected manner
 
-When you feel like your code is in a good place, please open an appropriate PR (Pull Request), answer the comprehension questions that appear when creating that PR, and submit!
+When you feel like your code is in a good place, please open an appropriate PR (Pull Request), answer the reflection questions that appear when creating that PR, and submit!
 
 ## Wrap up
 

feedback.md

@@ -1,12 +1,80 @@
 # Ride Share
-## What We're Looking For
-
-Feature 	| Feedback
----	      | ---
-Answers the comprehension questions |
-Readable code with consistent indentation and reasonable code style |
-Outputs the correct number of rides each driver has given |
-Outputs the total amount of money each driver has made |
-Outputs the average rating for each driver |
-Outputs which driver made the most money |
-Outputs which driver has the highest average rating |
+
+<!-- Instructors: The checkmarks are already there, so just delete them for any line items that aren't met. -->
+
+## Major Learning Goals/Code Review
+
+<!-- Instructors: Feel free to practice creating specific feedback by referencing a line of code if you'd like. For example, you may say something like "nice custom method in `calculator.rb` line 42." This is optional. -->
+
+| Criteria | yes/no, and optionally any details/lines of code to reference |
+| --- | --- |
+| Correctly creates, reads, and modifies variables | ✔️
+| Correctly creates and accesses arrays | ✔️
+| Correctly creates and accesses hashes | ✔️
+| Reasonably organizes large amounts of related data into nested arrays and hashes | ✔️
+| Correctly iterates through a nested data structure using loops and/or Enumerable methods | ✔️
+| Reasonably organizes small pieces of code into methods, and calls/invokes those methods | ✔️
+
+## Functional Requirements
+
+| Functional Requirement | yes/no |
+| --- | --- |
+| To the terminal, the program outputs the correct number of rides each driver has given | ✔️
+| ... outputs the total amount of money each driver has made | ✔️
+| ... outputs the average rating for each driver | ✔️
+| ... outputs which driver made the most money | ✔️
+| ... outputs which driver has the highest average rating | ✔️
+
+<!-- Answer Key:
+
+Driver amount of rides
+Driver 1: 3
+Driver 2: 3
+Driver 3: 2
+Driver 4: 3
+
+Total amount earned by each driver
+Driver 1: $85
+Driver 2: $75
+Driver 3: $55
+Driver 4: $35
+
+The average rating of Driver 1 is 3.0
+The average rating of Driver 2 is 3.0
+The average rating of Driver 3 is 3.5
+The average rating of Driver 4 is 4.67
+
+The driver who made the most money: Driver 1.
+The driver with the highest rating is Driver 4.
+
+Driver 1 made the most money on 5th Feb 2016
+Driver 2 made the most money on 5th Feb 2016
+Driver 3 made the most money on 5th Feb 2016
+Driver 4 made the most money on 5th Feb 2016
+ -->
+
+## Overall Feedback
+
+| Overall Feedback | Criteria | yes/no |
+| --- | --- | --- |
+| Green (Meets/Exceeds Standards) | 4+ in Code Review && 3+ in Functional Requirements | ✔️
+| Yellow (Approaches Standards) | 2-3 in Code Review && 2+ in Functional Requirements | ✔️
+| Red (Not at Standard) | 0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging | ✔️
+
+<!-- ### Additional Feedback -->
+
+<!-- Instructors, feel free to ignore this section if there's nothing else to add. -->
+
+## Code Style Bonus Awards
+
+<!-- Instructors: Please strike a balance between liberal/stingy with these. These are simply built-in pieces of positive feedback; use this to encourage and push students towards a cleaner code style! -->
+
+Was the code particularly impressive in code style for any of these reasons (or more...?)
+
+| Quality | Yes? |
+| --- | --- |
+| Perfect Indentation | ✅
+| Elegant/Clever | ✅
+| Descriptive/Readable | ✅
+| Concise | ✅
+| Logical/Organized | ✅