Fix typo & Fix app_id requirement and default #124
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeissner
reviewed
Jan 11, 2025
There was a problem hiding this comment.
HI @StevenH1901,
Thank you for opening this PR, Some things need to be in place before we can merge it.
- combine all fix type commits to a single commit
- add a test for checking the behavior of the app_id parameter, ideally for all common parameters
- extend the section test to check the list_order parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the section_module docs (and all other modules), app_id is not a required parameter and should default to 'ansible'.
When running version 1.7.0, I receive an error saying that 'app_id' is a required parameter. This error may be present in previous versions, but I have not verified.
Fixes #123