Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by function fixed #721

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhirupPann
Copy link

@abhirupPann abhirupPann commented Jan 15, 2025

PR Fixes:

  • 1 It was not filtering out because some article has the value cohort=0
  • 2 Introduced an logical 'or' statement, where it will also filter articles with value cohort= {theSelectedCohortValue i.e 2 or 3} as well cohort=0

Resolves #716

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

As all the articles of db of the development setup has value cohort=0, all the articles are getting showed on clicking on cohort 2.0 or cohort 3.0. But in production db I believe some articles has value cohort =0, cohort=2 and cohort=3, so only the articles with the given 'cohort' value and 0 value will be selected.
Demo:

Before:
https://github.com/user-attachments/assets/6b039e29-e01a-42e3-8b4c-351fa795dcae

After:
https://github.com/user-attachments/assets/8cbc82f6-8410-4bfb-a2a4-ba8b47fe415e

@abhirupPann
Copy link
Author

Hey @SujithThirumalaisamy , Can you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug:Sort By not working properly
1 participant