[compiler][ez] Fix main (bad rebase / amend for facebook#32095) (face…

…book#32160) See title: this fixes test cases broken by facebook#32095 adding instead of moving new test fixtures
code · Jan 22, 2025 · a0b91fb · a0b91fb
1 parent b83090f
commit a0b91fb
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 221 deletions.
diff --git a/compiler/packages/babel-plugin-react-compiler/src/HIR/ObjectShape.ts b/compiler/packages/babel-plugin-react-compiler/src/HIR/ObjectShape.ts
@@ -569,7 +569,7 @@ addObject(BUILTIN_SHAPES, BuiltInMixedReadonlyId, [
     'flatMap',
     addFunction(BUILTIN_SHAPES, [], {
       positionalParams: [],
-      restParam: Effect.Read,
+      restParam: Effect.ConditionallyMutate,
       returnType: {kind: 'Object', shapeId: BuiltInArrayId},
       calleeEffect: Effect.ConditionallyMutate,
       returnValueKind: ValueKind.Mutable,
@@ -580,7 +580,7 @@ addObject(BUILTIN_SHAPES, BuiltInMixedReadonlyId, [
     'filter',
     addFunction(BUILTIN_SHAPES, [], {
       positionalParams: [],
-      restParam: Effect.Read,
+      restParam: Effect.ConditionallyMutate,
       returnType: {kind: 'Object', shapeId: BuiltInArrayId},
       calleeEffect: Effect.ConditionallyMutate,
       returnValueKind: ValueKind.Mutable,

diff --git a/...r/src/__tests__/fixtures/compiler/bug-invalid-mixedreadonly-map-shape.expect.md b/...r/src/__tests__/fixtures/compiler/bug-invalid-mixedreadonly-map-shape.expect.md
diff --git a/...gin-react-compiler/src/__tests__/fixtures/compiler/bug-invalid-mixedreadonly-map-shape.js b/...gin-react-compiler/src/__tests__/fixtures/compiler/bug-invalid-mixedreadonly-map-shape.js