Merged PR 86225: BF OAS - fix source account required fields

codatio · Jan 24, 2025 · 81af787 · 81af787
1 parent cf27962
commit 81af787
Show file tree

Hide file tree

Showing 4 changed files with 56 additions and 16 deletions.
diff --git a/json/Codat-Bank-Feeds.json b/json/Codat-Bank-Feeds.json
@@ -3341,13 +3341,13 @@
                   {
                     "type": "array",
                     "items": {
-                      "$ref": "#/components/schemas/SourceAccountV2"
+                      "$ref": "#/components/schemas/SourceAccountV2/definitions/sourceAccountV2Prototype"
                     }
                   },
                   {
                     "type": "array",
                     "items": {
-                      "$ref": "#/components/schemas/SourceAccount"
+                      "$ref": "#/components/schemas/SourceAccount/definitions/sourceAccountPrototype"
                     }
                   }
                 ]
@@ -6935,7 +6935,7 @@
         ],
         "definitions": {
           "sourceAccountPrototype": {
-            "title": "Source account prototype",
+            "title": "Source account (v1)",
             "type": "object",
             "properties": {
               "id": {
@@ -6962,7 +6962,10 @@
               "modifiedDate": {
                 "$ref": "#/components/schemas/SourceAccount/properties/modifiedDate"
               }
-            }
+            },
+            "required": [
+              "id"
+            ]
           },
           "sourceAccounts": {
             "title": "Source accounts",
@@ -7151,7 +7154,7 @@
         ],
         "definitions": {
           "sourceAccountV2Prototype": {
-            "title": "Source account version 2 prototype",
+            "title": "Source account (v2)",
             "type": "object",
             "properties": {
               "id": {
@@ -7184,7 +7187,15 @@
               "accountInfo": {
                 "$ref": "#/components/schemas/SourceAccountV2/definitions/accountInfo"
               }
-            }
+            },
+            "required": [
+              "id",
+              "accountName",
+              "accountType",
+              "accountNumber",
+              "currency",
+              "balance"
+            ]
           },
           "accountInfo": {
             "title": "Account Info",

diff --git a/json/Codat-Lending.json b/json/Codat-Lending.json
@@ -121885,7 +121885,7 @@
         ],
         "definitions": {
           "sourceAccountPrototype": {
-            "title": "Source account prototype",
+            "title": "Source account (v1)",
             "type": "object",
             "properties": {
               "id": {
@@ -121912,7 +121912,10 @@
               "modifiedDate": {
                 "$ref": "#/components/schemas/SourceAccount/properties/modifiedDate"
               }
-            }
+            },
+            "required": [
+              "id"
+            ]
           },
           "sourceAccounts": {
             "title": "Source accounts",
@@ -122030,7 +122033,7 @@
         ],
         "definitions": {
           "sourceAccountV2Prototype": {
-            "title": "Source account version 2 prototype",
+            "title": "Source account (v2)",
             "type": "object",
             "properties": {
               "id": {
@@ -122063,7 +122066,15 @@
               "accountInfo": {
                 "$ref": "#/components/schemas/SourceAccountV2/definitions/accountInfo"
               }
-            }
+            },
+            "required": [
+              "id",
+              "accountName",
+              "accountType",
+              "accountNumber",
+              "currency",
+              "balance"
+            ]
           },
           "accountInfo": {
             "title": "Account Info",

diff --git a/yaml/Codat-Bank-Feeds.yaml b/yaml/Codat-Bank-Feeds.yaml
@@ -2293,10 +2293,10 @@ paths:
               oneOf:
                 - type: array
                   items:
-                    $ref: '#/components/schemas/SourceAccountV2'
+                    $ref: '#/components/schemas/SourceAccountV2/definitions/sourceAccountV2Prototype'
                 - type: array
                   items:
-                    $ref: '#/components/schemas/SourceAccount'
+                    $ref: '#/components/schemas/SourceAccount/definitions/sourceAccountPrototype'
       responses:
         '201':
           description: Success
@@ -4906,7 +4906,7 @@ components:
         - id
       definitions:
         sourceAccountPrototype:
-          title: Source account prototype
+          title: Source account (v1)
           type: object
           properties:
             id:
@@ -4925,6 +4925,8 @@ components:
               $ref: '#/components/schemas/SourceAccount/properties/balance'
             modifiedDate:
               $ref: '#/components/schemas/SourceAccount/properties/modifiedDate'
+          required:
+            - id
         sourceAccounts:
           title: Source accounts
           type: array
@@ -5070,7 +5072,7 @@ components:
         - balance
       definitions:
         sourceAccountV2Prototype:
-          title: Source account version 2 prototype
+          title: Source account (v2)
           type: object
           properties:
             id:
@@ -5093,6 +5095,13 @@ components:
               $ref: '#/components/schemas/SourceAccountV2/properties/modifiedDate'
             accountInfo:
               $ref: '#/components/schemas/SourceAccountV2/definitions/accountInfo'
+          required:
+            - id
+            - accountName
+            - accountType
+            - accountNumber
+            - currency
+            - balance
         accountInfo:
           title: Account Info
           type: object

diff --git a/yaml/Codat-Lending.yaml b/yaml/Codat-Lending.yaml
@@ -84841,7 +84841,7 @@ components:
         - id
       definitions:
         sourceAccountPrototype:
-          title: Source account prototype
+          title: Source account (v1)
           type: object
           properties:
             id:
@@ -84860,6 +84860,8 @@ components:
               $ref: '#/components/schemas/SourceAccount/properties/balance'
             modifiedDate:
               $ref: '#/components/schemas/SourceAccount/properties/modifiedDate'
+          required:
+            - id
         sourceAccounts:
           title: Source accounts
           type: array
@@ -84955,7 +84957,7 @@ components:
         - balance
       definitions:
         sourceAccountV2Prototype:
-          title: Source account version 2 prototype
+          title: Source account (v2)
           type: object
           properties:
             id:
@@ -84978,6 +84980,13 @@ components:
               $ref: '#/components/schemas/SourceAccountV2/properties/modifiedDate'
             accountInfo:
               $ref: '#/components/schemas/SourceAccountV2/definitions/accountInfo'
+          required:
+            - id
+            - accountName
+            - accountType
+            - accountNumber
+            - currency
+            - balance
         accountInfo:
           title: Account Info
           type: object