Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add log-paths to docker run parameters #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oleksandr-ivanov-ah
Copy link

I have added missed --log-paths parameter to the /bin/git-version execution

@oleksandr-ivanov-ah
Copy link
Author

@h314to Hello. Could you please review this small hotfix

@oleksandr-ivanov-ah
Copy link
Author

It is very difficult to contribute to your repo if you reviewing 2 line changes for more then 2 month

@oleksandr-ivanov-ah
Copy link
Author

@h314to can you please have a look at the PR

@h314to
Copy link
Contributor

h314to commented Feb 16, 2023

Build fails

@oleksandr-ivanov-ah
Copy link
Author

oleksandr-ivanov-ah commented Mar 16, 2023

@h314to the pipelines fails with error:
E: Repository 'https://cli-assets.heroku.com/apt ./ InRelease' changed its 'Origin' value from 'Heroku' to 'Jeff Dickey @jdxcode'
This error dosn't related to my pr changes. I just added 1 line in acrion yaml file:
--log-paths="${{ inputs.log-paths }}"

There couple of opened issues that can't solved by my pr ( [CY-6648] log-paths is unused and [TS-192 Monorepo prefix does not pick up last version](#81) ).

From the consumer perspective codacy doesn't support it's github actions, I already switched to release-please from google.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants