-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/refactor_TCE-771_TCE-735_TCE-779 #4291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
codacy-vrhpires
commented
Jan 25, 2024
•
edited
Loading
edited
- added plugin react-refresh
- security and security-node had discrepancies in categorization and severity
- fixed bug related to how a config file (in the repo) was detected and used
- reverted .eslintrc config file support deprecation
- styling patterns were deprecated in @typecript-eslint package and moved to a separate package
- a new parsing method for those rules was implemented because it didn’t follow current pattern /docs/rules/*.md
- node-fetch was converted to ESM so its usage was replaced by axios and the package removed
- docs/description folder is now emptied every time documentation is generated to purge deprecated patterns description files
- updated scripts section in package.json to follow current styling
- added eslint script (and styling rules) to fix the tool code styling automatically
- added upgrade script to upgrade and install all packages and then generate docs in a single command
- improved dockerfile efficiency
- added test to assert description.json and patterns.json are created
- refactored docGenerator class to streamline its usage in docGeneratorMain
- removed need to parse package.json to retrieve Eslint version in toolmetada
stefanvacareanu7
previously approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of removed patterns. Was this intended? Reading the description, not all of those are included.
Other than this, LGTM!
mrfyda
reviewed
Jan 26, 2024
mrfyda
reviewed
Jan 26, 2024
mrfyda
reviewed
Jan 26, 2024
stefanvacareanu7
previously approved these changes
Jan 26, 2024
mrfyda
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.