-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force-commit-sha input #83
Conversation
FYI, PR is ready for review, I opened it as draft to avoid bothering people in case you don't want it 😉 |
43084e1
to
e8bf406
Compare
Hi @yoanm, |
Hello 👋 However, I'm pretty sure adding that option would be worth the extra maintenance cost and may help people in specific cases. It's ultimately up to you though 😉 I let you close the PR if you believe it's not worthwhile |
Taking advantage of the PR to say that latest repo tag is more than 2 years old and doesn't include latest updates, not sure if it's expected or not. I had hard time figuring out the EDIT: It doesn't even seem to be linked to anything currently on master branch actually => https://github.com/codacy/codacy-coverage-reporter-action/tree/89d6c85cfafaec52c72b6c5e8b2878d33104c699 => "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.", a bit scary 😨 |
…verage-reporter-action into feature/force-commit-sha
For those needing the option, it's available there: https://github.com/yoanm/codacy-coverage-reporter-action/tree/master N.B.: FYI @lolgab, another nice thing with that option is the ability to avoid code checkout (for security purpose) and still be able to upload coverage data generated somewhere else. |
Simple PR adding a
force-commit-sha
input.While the workaround proposed there (=relying on the CLI directly) actually works when you have to deal with
workflow_run
executions, it has at least one major downside.In case I want to keep the CLI version up to date, I need to either
Also,
workflow_run
seems the most secure/reliable way to deal with forked PR, but as stated on #78 the CLI uploader doesn't correctly handle that case. So adding the input would bring a nice workaround for issues like #33, #67 or #69 for instance.Another way to cover the case would be to update the
GitHubActionProvider
from the CLI uploader directly (like did there codacy/codacy-coverage-reporter#492), in order to manageworkflow_run
events, but I guess it would require way more than just the few lines added there.Feel free to suggest any updates (input name/description, etc).