New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wallet][MS-336] Custom wallet for coins/nft #604

Merged

tanlethanh merged 31 commits into dev from ltminhthu/custom-wallet

Aug 9, 2024

Contributor

ltminhthu commented Jul 30, 2024

No description provided.

ltminhthu added 12 commits

July 22, 2024 21:11


          init custom wallet

ea7b446


          construct a custom wallet

59ead0b


          add assets for samo widget

8f7c4d6


          revert explorer

5c6388b


          adjust custom wallet layout

a0e8f11


          add advertisement for custom wallet

08790d1


          adjust some related functions

584e1ab


          add more ads and ads indicator

01e3045


          add ads indicator to the ads

3191fa7


          filter out the custom wallet when users have no required tokens

db08ef9


          fix some small details such as types, size, etc.

e967e3f


          hndle case wrapped sol is inserted

c9d2f38

notion-workspace bot commented Jul 30, 2024

Wallet Template for Coins / NFT

ltminhthu self-assigned this

ltminhthu requested a review from halv1s

July 30, 2024 04:19

ltminhthu added 3 commits

July 30, 2024 12:51


          refactor: filter out the custom wallet meet the requirement

325fd43


          fix: type check error


          fix: get wrong collection id

23c0c9d

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Explorer/index.tsx Outdated Show resolved Hide resolved

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Explorer/index.tsx Outdated Show resolved Hide resolved

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Explorer/index.tsx Outdated Show resolved Hide resolved

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Explorer/index.tsx Outdated Show resolved Hide resolved

Member

tanlethanh commented Aug 1, 2024

typescript "strictNullCheck"

type GenericWidget = {
   type: "SAMO_WIDGET" | "CUSTOM_A"
} & SamoWidget & UnknownWidget;

type SamoWidget = {
   type: "SAMO_WIDGET"
   abc: string
}

function renderWidget(widget: GenericWidget){
   if (widget.type === "SAMO_WIDGET") {
      // widget will be automatically casted to SamoWidget
      console.log(widget.abc) // no type error
   }
}

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Widget/BuiltInNetwork/AptosTokensTab/index.tsx Outdated Show resolved Hide resolved

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Widget/BuiltInNetwork/TokenTab.tsx Outdated Show resolved Hide resolved

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Widget/BuiltInNetwork/index.tsx Outdated Show resolved Hide resolved

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Widget/CustomWalletLayout/Advertisement/AdvertisementIndicator.tsx Show resolved Hide resolved

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Widget/CustomWalletLayout/Advertisement/AdvertisementIndicator.tsx Show resolved Hide resolved

apps/wallet/src/features/Widget/CustomWalletLayout/Advertisement/index.tsx Outdated Show resolved Hide resolved

apps/wallet/src/features/Widget/CustomWalletLayout/FeatureButtons.tsx Show resolved Hide resolved

apps/wallet/src/features/Widget/CustomWalletLayout/NftTab.tsx Outdated Show resolved Hide resolved

apps/wallet/src/modals/RemoveLayout.tsx Show resolved Hide resolved

apps/wallet/src/stacks/Explorer/WidgetNavigator/NavigatorOrb.tsx Outdated Show resolved Hide resolved

apps/wallet/src/state/widget/shared.ts Outdated Show resolved Hide resolved

apps/wallet/src/state/widget/shared.ts Outdated Show resolved Hide resolved

apps/wallet/src/state/widget/shared.ts Outdated Show resolved Hide resolved

ltminhthu added 2 commits

August 5, 2024 12:38


          replace nft tab by collectible list


          remove widget type, group it to widget category

b43a2b2

ltminhthu added 8 commits

August 5, 2024 12:43


          replace token tab by token list

0ac6cb1


          abstract filter for widget

ccb8b2a


          change data to widget

ebca821


          fix: type check

150020b


          keep the old style of slider tabs and add linear gradient

6fc0f21


          refactor: name the constant

6baa969


          fix: change icon size to optional

0dee521


          remove redundant log

5e90793

tanlethanh reviewed

View reviewed changes

apps/wallet/src/state/widget/shared.ts Outdated Show resolved Hide resolved

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Explorer/Widgets/CategoryButton.tsx Outdated Show resolved Hide resolved

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Explorer/index.tsx Outdated Show resolved Hide resolved

tanlethanh reviewed

View reviewed changes

apps/wallet/src/features/Widget/BuiltInNetwork/CollectibleList.tsx Outdated

Member

tanlethanh Aug 5, 2024

you should move it to components/

apps/wallet/src/utils/widget.ts Outdated Show resolved Hide resolved

ltminhthu added 6 commits

August 6, 2024 10:16


          update scroll animation for advertisement

696c0aa


          adjust the filter return from object to boolean

6f03cf5


          move token list and collectible list to components

0bdcc98


          combine category and subcategory of widget

d04a81f


          update type after changing the way to classify widgets

b8d3351


          fix: eslint

ea75b52

tanlethanh approved these changes

View reviewed changes

tanlethanh merged commit 27e0cca into dev

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet