Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wallet][MS-245] first time user popup for adding pixeverse #594

Merged
merged 9 commits into from
Aug 9, 2024
Merged

[wallet][MS-245] first time user popup for adding pixeverse #594

merged 9 commits into from
Aug 9, 2024

Conversation

ltminhthu
Copy link
Contributor

No description provided.

@notion-workspace Notion Workspace
Copy link

UI — Popup for first time user

@halv1s halv1s assigned halv1s and ltminhthu and unassigned halv1s Jul 10, 2024
@ltminhthu ltminhthu requested a review from tanlethanh July 19, 2024 09:19
tanlethanh
tanlethanh reviewed Aug 1, 2024
View reviewed changes
apps/wallet/src/stacks/Dashboard/index.tsx
@@ -15,6 +25,24 @@ const Tab = createBottomTabNavigator<DashboardParamList>();

export const DashboardStack = () => {
useNotificationPermissionRequest();
const { showFirstTimePopup: showPopup } = useSnapshot(appState);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this alias

tanlethanh
tanlethanh reviewed Aug 1, 2024
View reviewed changes
packages/store/plugins/clear.ts
export async function clearAllDocs(this: PouchDB.Database) {
export async function clearAllDocs(
this: PouchDB.Database,
whitelist: string[] = [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonResetWhitelist

@tanlethanh tanlethanh merged commit 70197ab into dev Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halv1s halv1s halv1s left review comments

@tanlethanh tanlethanh tanlethanh approved these changes

Assignees

@ltminhthu ltminhthu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ltminhthu @halv1s @tanlethanh