-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/#26 ] 댓글 컴포넌트 구현 #32
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7fab75c
feat: 댓글기능 초기세팅
Leeyoonji23 2199e41
feat: 아이콘 추가
Leeyoonji23 6762b2a
feat: 목데이터 만들기
Leeyoonji23 f0851af
feat: 댓글 컴포넌트
Leeyoonji23 cb5b42e
main 돌려놓기!
Leeyoonji23 d05b6df
Merge branch 'feat/#26/comment' of https://github.com/SOPT-all/35-APP…
ocahs9 d98f5b7
fix: px -> rem 수정
Leeyoonji23 0fbd12d
Merge branch 'feat/#26/comment' of https://github.com/SOPT-all/35-APP…
Leeyoonji23 939c726
fix: svg 이름 수정
Leeyoonji23 6c73a94
fix: 내용 넘치지 않게 수정
Leeyoonji23 6e78357
fix: props, interface 추가
Leeyoonji23 555cd9d
fix: 답글 부분 간소화
Leeyoonji23 1784d8d
fix: text 스타일 수정
Leeyoonji23 d42aa85
Merge branch 'develop' into feat/#26/comment
ocahs9 08adcce
fix: 충돌 처리
ocahs9 b7d954e
Merge branch 'feat/#26/comment' of https://github.com/SOPT-all/35-APP…
ocahs9 a31aa11
feat: 필요없는 import 제거
ocahs9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import * as React from "react"; | ||
import type { SVGProps } from "react"; | ||
const SvgIcEllipse57 = (props: SVGProps<SVGSVGElement>) => ( | ||
<svg | ||
xmlns="http://www.w3.org/2000/svg" | ||
width={32} | ||
height={32} | ||
fill="none" | ||
{...props} | ||
> | ||
<circle cx={16} cy={16} r={16} fill="#E4E4E4" /> | ||
</svg> | ||
); | ||
export default SvgIcEllipse57; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import * as React from "react"; | ||
import type { SVGProps } from "react"; | ||
const SvgIcEllipses = (props: SVGProps<SVGSVGElement>) => ( | ||
<svg | ||
xmlns="http://www.w3.org/2000/svg" | ||
width={22} | ||
height={22} | ||
fill="none" | ||
{...props} | ||
> | ||
<g | ||
stroke="#222" | ||
strokeLinecap="round" | ||
strokeLinejoin="round" | ||
strokeWidth={1.5} | ||
> | ||
<path d="M11 11.875a.875.875 0 1 0 0-1.75.875.875 0 0 0 0 1.75M11 5.75A.875.875 0 1 0 11 4a.875.875 0 0 0 0 1.75M11 18a.875.875 0 1 0 0-1.75.875.875 0 0 0 0 1.75" /> | ||
</g> | ||
</svg> | ||
); | ||
export default SvgIcEllipses; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import * as React from "react"; | ||
import type { SVGProps } from "react"; | ||
const SvgIcMessage = (props: SVGProps<SVGSVGElement>) => ( | ||
<svg | ||
xmlns="http://www.w3.org/2000/svg" | ||
width={18} | ||
height={18} | ||
fill="none" | ||
{...props} | ||
> | ||
<path | ||
stroke="#BEBEBE" | ||
strokeLinecap="round" | ||
strokeLinejoin="round" | ||
strokeWidth={1.5} | ||
d="M5.625 9h.008M9 9h.008m3.367 0h.008M9 15.75a6.75 6.75 0 1 0-6.256-4.212c.06.15.09.225.104.286a.7.7 0 0 1 .019.164c0 .062-.012.13-.034.265l-.445 2.668c-.046.28-.07.42-.026.52a.38.38 0 0 0 .196.197c.101.044.241.02.52-.026l2.669-.445c.135-.022.203-.034.265-.034.06 0 .105.005.164.019s.136.043.286.105c.783.318 1.64.493 2.538.493M6 9a.375.375 0 1 1-.75 0A.375.375 0 0 1 6 9m3.375 0a.375.375 0 1 1-.75 0 .375.375 0 0 1 .75 0m3.375 0A.375.375 0 1 1 12 9a.375.375 0 0 1 .75 0" | ||
/> | ||
</svg> | ||
); | ||
export default SvgIcMessage; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
export { default as IcEllipse57 } from "./IcEllipse57"; | ||
export { default as IcEllipses } from "./IcEllipses"; | ||
export { default as IcMessage } from "./IcMessage"; | ||
export { default as Plus } from "./Plus"; | ||
export { default as React } from "./React"; | ||
export { default as Vite } from "./Vite"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
import { style } from "@vanilla-extract/css"; | ||
import { font, semanticColor } from "@style/styles.css"; | ||
|
||
export const commentContainer = style([ | ||
{ | ||
position: "relative", | ||
display: "flex", | ||
flexDirection: "column", | ||
width: "33.5rem", | ||
padding: "0.8rem 0rem", | ||
gap: "0.4rem", | ||
}, | ||
]); | ||
|
||
export const pStyle = style({ | ||
padding: "0rem, 1.1rem, 0rem, 4rem", | ||
}); | ||
|
||
export const containerOptionsIcon = style([ | ||
{ | ||
position: "absolute", | ||
left: "31.1rem", | ||
top: "0.8rem", | ||
}, | ||
]); | ||
|
||
export const commentItem = style([ | ||
{ | ||
display: "flex", | ||
alignItems: "flex-start", | ||
gap: "0.4rem", | ||
}, | ||
]); | ||
|
||
export const contentContainer = style([ | ||
{ | ||
flex: 1, | ||
display: "flex", | ||
flexDirection: "column", | ||
gap: "0.4rem", | ||
}, | ||
]); | ||
|
||
export const header = style([ | ||
{ | ||
display: "flex", | ||
alignItems: "center", | ||
gap: "0.8rem", | ||
}, | ||
]); | ||
|
||
export const headerInfo = style([ | ||
{ | ||
display: "flex", | ||
flexDirection: "column", | ||
}, | ||
]); | ||
|
||
export const nickname = style([ | ||
font.label01, | ||
{ | ||
fontWeight: 600, | ||
color: semanticColor.text.assistive, | ||
letterSpacing: "-0.024rem", | ||
}, | ||
]); | ||
|
||
export const meta = style([ | ||
font.label01, | ||
{ | ||
color: semanticColor.text.assistive, | ||
fontWeight: 500, | ||
letterSpacing: "-0.024rem", | ||
}, | ||
]); | ||
|
||
export const text = style([ | ||
font.heading03, | ||
{ | ||
color: semanticColor.text.normal, | ||
fontWeight: "500", | ||
lineHeight: "2.24rem", | ||
letterSpacing: "-0.16rem", | ||
padding: "0rem 1.1rem 0rem 4rem", | ||
}, | ||
]); | ||
|
||
export const replyContainer = style([ | ||
{ | ||
display: "flex", | ||
alignItems: "center", | ||
padding: "0rem 1.1rem 0rem 4rem", | ||
}, | ||
]); | ||
|
||
export const replyText = style([ | ||
font.label01, | ||
{ | ||
color: semanticColor.text.assistiveLight, | ||
}, | ||
]); | ||
|
||
export const icon = style([ | ||
{ | ||
gap: "0.4rem", | ||
}, | ||
]); | ||
|
||
export const profileImage = style({ | ||
width: "3.2rem", | ||
height: "3.2rem", | ||
borderRadius: "50%", | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3) replyText와 icon이 항상 함께 사용되는데, 스타일을 따로 분리해서 작성하신 이유가 있을실까요?? 다음과 같이 한 번에 사용하지 않고 따로 사용하신 이유가 있는지 궁금합니다!
스타일이 달라지는 것이 아니라면, 한 번에 사용하는 것이 가독성에 더 좋지 않을까 싶어 남겨봅니다..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 처음엔 피그마를 기반으로 replyContainer 하나, 그 안에 답글 이모티콘과 답글쓰기 태그를 따로 보고 구현했습니다!
그런데 예림님 말씀 듣고 보니 저렇게 하는게 훨씬 더 가독성이 좋네요 👏❤️ 관련사항 반영하여 수정했습니다 ! 감사합니다❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영해서 다른 것들도 수정했씁니다 ❤️❤️