[WIP] oraclelogminer: support simple LOB and timezone types #1111
+545
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The logic LGTM! Thanks for adding the tests too |
ZhouXing19
force-pushed
the
oracle-source-0826
branch
from
0cadea2 to
b1318b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timezones need to be handled in a custom manner because of how the data comes in as
TO_TIMSTAMPTZwhich will need the function applied to the data inside.Additionally, we need to process simple LOBs so that we replace
EMPTY_CLOBorEMPTY_BLOBdirectives with empty strings so they insert empty BLOB/CLOB types; this also needs specialized processing for us to handle the HEX2RAW case which will need to turn the data to a bytestring.Resolves: CC-31049, CC-31048 (partially)
Release Note: None
This change is