Database version backups #1000
Open
Database version backups #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattWhelan
force-pushed
the
missingTarget
branch
from
7b4f803 to
fe36a7a
Compare
|
This is a pretty small change. As I'm heading out on PTO for two weeks, feel free to may any changes you see fit to make in my absence. There isn't an automated integration test. I had to manually run through the process of setting up an initial changefeed so that the schema/version would be cached, and then using |
MattWhelan
force-pushed
the
missingTarget
branch
from
fe36a7a to
9a5c338
Compare
MattWhelan
force-pushed
the
missingTarget
branch
from
ab54aec to
040f2be
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MattWhelan
force-pushed
the
missingTarget
branch
from
baba4cc to
2c76cd0
Compare
MattWhelan
force-pushed
the
missingTarget
branch
from
2c76cd0 to
d23e8a8
Compare
This allows replicator to start without the database. Added a shell script to run precommit checks at qol/fmt.sh.
MattWhelan
force-pushed
the
missingTarget
branch
from
d23e8a8 to
244cc42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the database version string to detect the product and version of the database (and thus the SQL dialect, among other things). That happens at connection time, so we need to restore the version from the memo if the target DB is down.
I made a few tweaks to the workload tools to test this with Oracle.
This change is