Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom fields to self signer jobs #373

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Add custom fields to self signer jobs #373

merged 7 commits into from
Sep 18, 2024

Conversation

81887821
Copy link
Contributor

Currently annotations, affinity, node selector and tolerations are only applied to self signer init job. It would be better if those are also applied to rotate cronjobs and clean-up job.
My use case is to disable Istio sidecar injection to the clean-up job.

@umi0410
Copy link

umi0410 commented Jan 31, 2024

It will be great supporting both additional labels and annotations.
For your reference, the current related code is here:

metadata:
name: {{ template "selfcerts.fullname" . }}-cleaner
labels:
helm.sh/chart: {{ template "cockroachdb.chart" . }}
app.kubernetes.io/name: {{ template "cockroachdb.name" . }}
app.kubernetes.io/instance: {{ .Release.Name | quote }}
app.kubernetes.io/managed-by: {{ .Release.Service | quote }}

@81887821 81887821 changed the title Add annotations, affinity, node selector and tolerations to self signer jobs Add custom fields to self signer jobs Feb 1, 2024
@81887821
Copy link
Contributor Author

81887821 commented Feb 1, 2024

Added support for labels

@rail rail requested a review from prafull01 February 16, 2024 12:11
@udnay
Copy link

udnay commented Sep 6, 2024

@prafull01 can you take a look at this please?

@81887821 can you please rebase with master?

@81887821
Copy link
Contributor Author

@udnay done

@prafull01
Copy link
Collaborator

LGTM, Approved. @81887821 Please rebase again, so that I can merge this change.

@rail rail enabled auto-merge (rebase) September 18, 2024 13:37
auto-merge was automatically disabled September 18, 2024 13:51

Rebase failed

@rail rail merged commit 7696781 into cockroachdb:master Sep 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants