-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom fields to self signer jobs #373
Conversation
…mplates use `nodeAffinity` * Bumped chart version
It will be great supporting both additional labels and annotations. helm-charts/cockroachdb/templates/job-cleaner.yaml Lines 20 to 26 in 0cba0b6
|
Added support for labels |
@prafull01 can you take a look at this please? @81887821 can you please rebase with master? |
@udnay done |
LGTM, Approved. @81887821 Please rebase again, so that I can merge this change. |
Currently annotations, affinity, node selector and tolerations are only applied to self signer init job. It would be better if those are also applied to rotate cronjobs and clean-up job.
My use case is to disable Istio sidecar injection to the clean-up job.