Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-11984 PR #135924 - sql: label latency histograms with statement fingerprint #19322

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Jan 27, 2025

Fixes DOC-11984

Renamed Child Metrics page to Multi-dimensional Metrics page. Added section Enable detailed latency metrics to Multi-dimensional Metrics page.

  • In available-metrics-in-metrics-list.csv, added sql.exec.latency.detail and sql.query.unique.count.
  • Renamed child-metrics.yml to multi-dimensional-metrics.yml, added sql.exec.latency.detail with detailed-latency feature and replaced child_metrics_id with multi_dimensional_metric_id.
  • Renamed child-metrics-table.md include file to multi-dimensional-metrics-table.md and updated to use multi_dimensional_metric_id and added check for detailed-latency.
  • Renamed child-metrics.md to multi-dimensional-metrics.md and updated includes to use multi-dimensional-metrics-table.md and added section Enable detailed latency metrics.
  • In sidebar-data/reference.json, set-up-logical-data-replication.md, and logical-data-replication-monitoring, updated link from child-metrics.md to multi-dimensional-metrics.md.

Rendered previews:

Updated child-metrics-table.md and metric-names.md to use page.version.version.

Updated cockroachcloud metrics-tab.md and metrics-essential.md to use site.current_cloud_version.
…mat=csv > metrics-list.csv against v25.1.0-beta.1, v24.3.3, v24.2.8. Manually lower-cased column headers.
Copy link

github-actions bot commented Jan 27, 2025

Files changed:

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 1ab3217
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/679d3423302e3400080163fc

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 1ab3217
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/679d34238fe2d4000850b53d

Copy link

netlify bot commented Jan 27, 2025

Netlify Preview

Name Link
🔨 Latest commit 1ab3217
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/679d3422fa744700080de68d
😎 Deploy Preview https://deploy-preview-19322--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Renamed child-metrics.yml to multi-dimensional-metrics.yml.
…il and sql.query.unique.count.

In multi-dimensional-metrics.yml, added sql.exec.latency.detail with detailed-latency feature and replaced child_metrics_id with multi_dimensional_metric_id.

Renamed child-metrics-table.md include file to multi-dimensional-metrics-table.md and updated to use multi_dimensional_metric_id.

In multi-dimensional-metrics.md, updated includes to use multi-dimensional-metrics-table.md.

In sidebar-data/reference.json, set-up-logical-data-replication.md, and logical-data-replication-monitoring, updated link from child-metrics.md to multi-dimensional-metrics.md.
In multi-dimensional-metrics.md, added section Enable detailed latency metrics.
Copy link

@MattWhelan MattWhelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants