Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molt fetch fixes #19294

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Molt fetch fixes #19294

merged 6 commits into from
Jan 16, 2025

Conversation

taroface
Copy link
Contributor

DOC-12006
DOC-11690
DOC-11667

  • Document --import-region flag.
  • Fix type mapping JSON format.
  • Mention MOLT Fetch as first option for loading data in migration tutorials. (This is a quick fix; the tutorial steps aren't updated to use Fetch yet. This will be tracked separately.)

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 869fc1c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/678937a01e93df00082ed7a2

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 869fc1c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/678937a1875aa500085cebe7

Copy link

netlify bot commented Jan 10, 2025

Netlify Preview

Name Link
🔨 Latest commit 869fc1c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/678937a0bd1c9b0008e8fa00
😎 Deploy Preview https://deploy-preview-19294--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taroface
Copy link
Contributor Author

@ZhouXing19 Is --import-region actually required when using S3? If so, I'll add that to the flag description.

@ZhouXing19
Copy link
Contributor

@ZhouXing19 Is --import-region actually required when using S3? If so, I'll add that to the flag description.

It is not required until the user needs to specify the AWS_REGION as part of the import bucket argument.

Say if the IMPORT stmt require a path:

s3://molt-fetch?AWS_ACCESS_KEY_ID=<AWS_ACCESS_KEY_ID>&AWS_SECRET_ACCESS_KEY=<AWS_SECRET_ACCESS_KEY>&AWS_SESSION_TOKEN=<AWS_SESSION_TOKEN>&AWS_REGION=ap-south-1'

They need to specify --import-region=ap-south-1 to have AWS_REGION=ap-south-1 append to the final import path used by molt

@taroface
Copy link
Contributor Author

@ZhouXing19 Is --import-region actually required when using S3? If so, I'll add that to the flag description.

It is not required until the user needs to specify the AWS_REGION as part of the import bucket argument.

Say if the IMPORT stmt require a path:

s3://molt-fetch?AWS_ACCESS_KEY_ID=<AWS_ACCESS_KEY_ID>&AWS_SECRET_ACCESS_KEY=<AWS_SECRET_ACCESS_KEY>&AWS_SESSION_TOKEN=<AWS_SESSION_TOKEN>&AWS_REGION=ap-south-1'

They need to specify --import-region=ap-south-1 to have AWS_REGION=ap-south-1 append to the final import path used by molt

Thanks for this -- I attempted to clarify in the latest commit.

@taroface taroface requested a review from florence-crl January 14, 2025 21:14
Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending 1 suggestion

src/current/molt/molt-fetch.md Outdated Show resolved Hide resolved
@taroface taroface enabled auto-merge (squash) January 16, 2025 16:45
@taroface taroface merged commit e0fa876 into main Jan 16, 2025
7 checks passed
@taroface taroface deleted the molt-fetch-fixes branch January 16, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants