tasks: add python3-mypy, pytest modules #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to stop using toxbox to run our static checks against a venv and start depending on the run from the tasks container instead. We need mypy in the tasks container for that, of course. While we're at it, add python3-pytest. Something else we're already using (probably aioresponses) is pulling that in implicitly, but it's pretty important for us, so make sure we have it explicitly. Add a couple of more useful pytest modules as well...
allisonkarlitskaya
temporarily deployed
to
quay.io
GitHub Actions
Inactive
|
As this is the container refresh which we wanted to do anyway, can we please land cockpit-project/cockpit-machines#1484 first? |
martinpitt
previously approved these changes
Mar 11, 2024
We also need this for test/static-code in cockpit repo.
allisonkarlitskaya
temporarily deployed
to
quay.io
GitHub Actions
Inactive
martinpitt
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to stop using toxbox to run our static checks against a venv and start depending on the run from the tasks container instead. We need mypy in the tasks container for that, of course.
While we're at it, add python3-pytest. Something else we're already using (probably aioresponses) is pulling that in implicitly, but it's pretty important for us, so make sure we have it explicitly.
Add a couple of more useful pytest modules as well...
https://github.com/cockpit-project/cockpituous/actions/runs/8231372303/job/22506531777https://github.com/cockpit-project/cockpituous/actions/runs/8231519767