Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Update Cockpit lib to 11a740cbca185e4adba9c5abb06fd205 #756

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

github-actions[bot]
Copy link

Jelle van der Waa (1):
lib: shell: tabIndex property only accepts integer values

Marius Vollmer (5):
lib: Revert menu toggles to be transparent again
lib: Type ListingTable
shell: Fully type "topnav"
test: Add tests for MultiTypeaheadSelect
lib: Add types to pkg/lib/notifications

Martin Pitt (2):
test: Use real mouse events with Chromium in the shell
test: Adjust types to python pillow 11.0

@github-actions github-actions bot added the bot label Dec 19, 2024
@github-actions github-actions bot changed the title [no-test] Makefile: Update Cockpit lib to 11a740cbca185e4adba9c5abb06fd205 Makefile: Update Cockpit lib to 11a740cbca185e4adba9c5abb06fd205 Dec 19, 2024
@github-actions github-actions bot force-pushed the cockpit-lib-update-cockpit-lib-20241219-025223 branch from 0aea19c to 021ef35 Compare December 19, 2024 02:52
@martinpitt
Copy link
Member

So, what now? What on earth does this pkg/lib update have to do with the eslint config? static-code didn't change. Also, the errors are bogus -- import grouping is nice, but not in the way it wants us to do that.

@martinpitt
Copy link
Member

Oh! .jsx → .tsx!

@martinpitt martinpitt force-pushed the cockpit-lib-update-cockpit-lib-20241219-025223 branch from 021ef35 to 62ec702 Compare December 19, 2024 04:46
@martinpitt martinpitt requested a review from mvollmer December 19, 2024 05:18
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvollmer mvollmer merged commit e720670 into main Dec 19, 2024
7 checks passed
@mvollmer mvollmer deleted the cockpit-lib-update-cockpit-lib-20241219-025223 branch December 19, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants